Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2919343002: Remove template parameter on ComputedStyleBase. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index 50dc4e572cf04b5179ad2ca2304fefc2cd0478f0..dd1dd2867930463b507693a7df43bfef1ed14867 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -442,6 +442,7 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):
self._include_paths = _get_include_paths(all_properties)
self._outputs = {
'ComputedStyleBase.h': self.generate_base_computed_style_h,
+ 'ComputedStyleBase.cpp': self.generate_base_computed_style_cpp,
'ComputedStyleBaseConstants.h': self.generate_base_computed_style_constants,
}
@@ -455,6 +456,16 @@ class ComputedStyleBaseWriter(make_style_builder.StyleBuilderWriter):
'diff_functions_map': self._diff_functions_map,
}
+ @template_expander.use_jinja('ComputedStyleBase.cpp.tmpl', tests={'in': lambda a, b: a in b})
+ def generate_base_computed_style_cpp(self):
+ return {
+ 'properties': self._properties,
+ 'enums': self._generated_enums,
+ 'include_paths': self._include_paths,
+ 'computed_style': self._root_group,
+ 'diff_functions_map': self._diff_functions_map,
+ }
+
@template_expander.use_jinja('ComputedStyleBaseConstants.h.tmpl')
def generate_base_computed_style_constants(self):
return {
« no previous file with comments | « no previous file | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698