Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4738)

Unified Diff: chrome/browser/permissions/permission_prompt_android.cc

Issue 2919323002: Support "learn more" link for EME in PermissionRequestManager code-path on Android (Closed)
Patch Set: fix var order Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_prompt_android.cc
diff --git a/chrome/browser/permissions/permission_prompt_android.cc b/chrome/browser/permissions/permission_prompt_android.cc
index 21c8cce02183dc0c05d9bdd4bcdcc03cea887398..a7376df8399a9591bae184f59ffe415fa24a5a4d 100644
--- a/chrome/browser/permissions/permission_prompt_android.cc
+++ b/chrome/browser/permissions/permission_prompt_android.cc
@@ -9,6 +9,9 @@
#include "chrome/browser/permissions/grouped_permission_infobar_delegate_android.h"
#include "chrome/browser/permissions/permission_dialog_delegate.h"
#include "chrome/browser/permissions/permission_request.h"
+#include "chrome/common/url_constants.h"
+#include "components/strings/grit/components_strings.h"
+#include "ui/base/l10n/l10n_util.h"
PermissionPromptAndroid::PermissionPromptAndroid(
content::WebContents* web_contents)
@@ -129,6 +132,20 @@ base::string16 PermissionPromptAndroid::GetMessageTextFragment(
return requests[position]->GetMessageTextFragment();
}
+base::string16 PermissionPromptAndroid::GetLinkText() const {
+ if (GetContentSettingType(0) ==
+ CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER)
raymes 2017/06/06 05:14:18 nit: {}
Timothy Loh 2017/06/06 09:29:15 Done.
+ return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
+ return base::string16();
+}
+
+GURL PermissionPromptAndroid::GetLinkURL() const {
+ if (GetContentSettingType(0) ==
+ CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER)
raymes 2017/06/06 05:14:18 nit: {}
Timothy Loh 2017/06/06 09:29:15 Done.
+ return GURL(chrome::kEnhancedPlaybackNotificationLearnMoreURL);
+ return GURL();
+}
+
// static
std::unique_ptr<PermissionPrompt> PermissionPrompt::Create(
content::WebContents* web_contents) {

Powered by Google App Engine
This is Rietveld 408576698