Support "learn more" link for EME in PermissionRequestManager code-path on Android

chrome/browser/ui/permission_bubble/mock_permission_prompt.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/ui/permission_bubble/mock_permission_prompt_factory.h"
 
 MockPermissionPrompt::~MockPermissionPrompt() {
   Hide();
 }
 
 void MockPermissionPrompt::Show() {
   factory_->ShowView(this);
   factory_->show_count_++;
   factory_->requests_count_ = manager_->requests_.size();
   for (const PermissionRequest* request : manager_->requests_) {
     factory_->request_types_seen_.push_back(
         request->GetPermissionRequestType());
+    // The actual prompt will call these, ensure we have test coverage.

[Timothy Loh, 2017/06/06 03:46:36]

Not sure if I should add an instrumentation test for EME or just do this. This
is simpler and adds coverage for other request types compared to a test for EME
so I preferred it.

[raymes, 2017/06/06 05:14:18]

I would rather check that the results are meaningful in some way. e.g. either by
storing the results in a member variable and comparing them in the test harness,
or just EXPECT'ing here that they are non-null.

[Timothy Loh, 2017/06/06 09:29:15]

Not sure this is really an appropriate place to have EXPECTs, but I added some.
WDYT?

[raymes, 2017/06/06 22:53:33]

It's definitely not ideal but I think it's slightly preferable to just calling
the functions. I consider this as part of the test infrastructure.

+    request->GetIconId();
+    request->GetMessageTextFragment();
+#if defined(OS_ANDROID)
+    request->GetMessageText();
+#endif
   }
   factory_->UpdateResponseType();
   is_visible_ = true;
 }
 
 bool MockPermissionPrompt::CanAcceptRequestUpdate() {
   return can_update_ui_;
 }
 
 bool MockPermissionPrompt::HidesAutomatically() {
@@ skipping 17 matching lines @@
 bool MockPermissionPrompt::IsVisible() {
   return is_visible_;
 }
 
 MockPermissionPrompt::MockPermissionPrompt(MockPermissionPromptFactory* factory,
                                            PermissionRequestManager* manager)
     : factory_(factory),
       manager_(manager),
       can_update_ui_(true),
       is_visible_(false) {}