Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: content/browser/service_worker/service_worker_url_job_wrapper.h

Issue 2919313004: Get rid of URLLoaderFactory in browser-side case (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_ 5 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_
6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_ 6 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "content/browser/loader/url_loader_request_handler.h" 10 #include "content/browser/loader/url_loader_request_handler.h"
11 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h" 11 #include "content/browser/service_worker/service_worker_fetch_dispatcher.h"
12 #include "content/browser/service_worker/service_worker_response_type.h" 12 #include "content/browser/service_worker/service_worker_response_type.h"
13 #include "content/browser/service_worker/service_worker_url_request_job.h" 13 #include "content/browser/service_worker/service_worker_url_request_job.h"
14 #include "storage/browser/blob/blob_reader.h" 14 #include "storage/browser/blob/blob_reader.h"
15 15
16 namespace content { 16 namespace content {
17 17
18 // This class is a helper to support having 18 // This class is a helper to support having
19 // ServiceWorkerControlleeRequestHandler work with both URLRequestJobs and 19 // ServiceWorkerControlleeRequestHandler work with both URLRequestJobs and
20 // mojom::URLLoaderFactorys (that is, both with and without 20 // mojom::URLLoaders (that is, both with and without --enable-network-service).
21 // --enable-network-service). It wraps either a ServiceWorkerURLRequestJob or a 21 // It wraps either a ServiceWorkerURLRequestJob or a callback for
22 // callback for URLLoaderFactory and forwards to the underlying implementation. 22 // URLLoader and forwards to the underlying implementation.
23 class ServiceWorkerURLJobWrapper { 23 class ServiceWorkerURLJobWrapper {
24 public: 24 public:
25 class Delegate { 25 class Delegate {
26 public: 26 public:
27 virtual ~Delegate() {} 27 virtual ~Delegate() {}
28 28
29 virtual ServiceWorkerVersion* GetServiceWorkerVersion( 29 virtual ServiceWorkerVersion* GetServiceWorkerVersion(
30 ServiceWorkerMetrics::URLRequestJobResult* result) = 0; 30 ServiceWorkerMetrics::URLRequestJobResult* result) = 0;
31 }; 31 };
32 32
33 // Non-network service case. 33 // Non-network service case.
34 explicit ServiceWorkerURLJobWrapper( 34 explicit ServiceWorkerURLJobWrapper(
35 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job); 35 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job);
36 36
37 // With --enable-network-service. 37 // With --enable-network-service.
38 // TODO(kinuko): Implement this as a separate job class rather 38 // TODO(kinuko): Implement this as a separate job class rather
39 // than in a wrapper. 39 // than in a wrapper.
40 ServiceWorkerURLJobWrapper( 40 ServiceWorkerURLJobWrapper(
41 LoaderFactoryCallback loader_factory_callback, 41 LoaderCallback loader_callback,
42 Delegate* delegate, 42 Delegate* delegate,
43 const ResourceRequest& resource_request, 43 const ResourceRequest& resource_request,
44 base::WeakPtr<storage::BlobStorageContext> blob_storage_context); 44 base::WeakPtr<storage::BlobStorageContext> blob_storage_context);
45 45
46 ~ServiceWorkerURLJobWrapper(); 46 ~ServiceWorkerURLJobWrapper();
47 47
48 // Sets the response type. 48 // Sets the response type.
49 void FallbackToNetwork(); 49 void FallbackToNetwork();
50 void FallbackToNetworkOrRenderer(); 50 void FallbackToNetworkOrRenderer();
51 void ForwardToServiceWorker(); 51 void ForwardToServiceWorker();
(...skipping 16 matching lines...) Expand all
68 size_t GetURLChainSize() const; 68 size_t GetURLChainSize() const;
69 69
70 // Returns true if the underlying job has been canceled or destroyed. 70 // Returns true if the underlying job has been canceled or destroyed.
71 bool WasCanceled() const; 71 bool WasCanceled() const;
72 72
73 private: 73 private:
74 enum class JobType { kURLRequest, kURLLoader }; 74 enum class JobType { kURLRequest, kURLLoader };
75 75
76 // Used only for URLLoader case. 76 // Used only for URLLoader case.
77 // For FORWARD_TO_SERVICE_WORKER case. 77 // For FORWARD_TO_SERVICE_WORKER case.
78 class Factory;
79 void StartRequest(); 78 void StartRequest();
80 79
81 void DidPrepareFetchEvent(scoped_refptr<ServiceWorkerVersion> version); 80 void DidPrepareFetchEvent(scoped_refptr<ServiceWorkerVersion> version);
82 void DidDispatchFetchEvent( 81 void DidDispatchFetchEvent(
83 ServiceWorkerStatusCode status, 82 ServiceWorkerStatusCode status,
84 ServiceWorkerFetchEventResult fetch_result, 83 ServiceWorkerFetchEventResult fetch_result,
85 const ServiceWorkerResponse& response, 84 const ServiceWorkerResponse& response,
86 blink::mojom::ServiceWorkerStreamHandlePtr body_as_stream, 85 blink::mojom::ServiceWorkerStreamHandlePtr body_as_stream,
87 const scoped_refptr<ServiceWorkerVersion>& version); 86 const scoped_refptr<ServiceWorkerVersion>& version);
88 87
89 std::unique_ptr<ServiceWorkerFetchRequest> CreateFetchRequest( 88 std::unique_ptr<ServiceWorkerFetchRequest> CreateFetchRequest(
90 const ResourceRequest& request); 89 const ResourceRequest& request);
91 90
92 void AfterRead(scoped_refptr<net::IOBuffer> buffer, int bytes); 91 void AfterRead(scoped_refptr<net::IOBuffer> buffer, int bytes);
93 92
94 JobType job_type_; 93 JobType job_type_;
95 94
96 ServiceWorkerResponseType response_type_ = NOT_DETERMINED; 95 ServiceWorkerResponseType response_type_ = NOT_DETERMINED;
97 LoaderFactoryCallback loader_factory_callback_; 96 LoaderCallback loader_callback_;
98 97
99 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job_; 98 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job_;
100 99
101 Delegate* delegate_; 100 Delegate* delegate_;
102 std::unique_ptr<Factory> factory_;
103 ResourceRequest resource_request_; 101 ResourceRequest resource_request_;
104 base::WeakPtr<storage::BlobStorageContext> blob_storage_context_; 102 base::WeakPtr<storage::BlobStorageContext> blob_storage_context_;
105 std::unique_ptr<ServiceWorkerFetchDispatcher> fetch_dispatcher_; 103 std::unique_ptr<ServiceWorkerFetchDispatcher> fetch_dispatcher_;
106 104
107 base::WeakPtrFactory<ServiceWorkerURLJobWrapper> weak_factory_; 105 base::WeakPtrFactory<ServiceWorkerURLJobWrapper> weak_factory_;
108 106
109 DISALLOW_COPY_AND_ASSIGN(ServiceWorkerURLJobWrapper); 107 DISALLOW_COPY_AND_ASSIGN(ServiceWorkerURLJobWrapper);
110 }; 108 };
111 109
112 } // namespace content 110 } // namespace content
113 111
114 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_ 112 #endif // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_JOB_WRAPPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698