Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Side by Side Diff: content/browser/service_worker/service_worker_url_job_wrapper.cc

Issue 2919313004: Get rid of URLLoaderFactory in browser-side case (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_url_job_wrapper.h" 5 #include "content/browser/service_worker/service_worker_url_job_wrapper.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "content/browser/service_worker/service_worker_response_type.h" 8 #include "content/browser/service_worker/service_worker_response_type.h"
9 #include "content/public/browser/resource_request_info.h" 9 #include "content/public/browser/resource_request_info.h"
10 #include "content/public/common/browser_side_navigation_policy.h" 10 #include "content/public/common/browser_side_navigation_policy.h"
11 #include "content/public/common/content_switches.h" 11 #include "content/public/common/content_switches.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper( 15 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper(
16 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job) 16 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job)
17 : job_type_(JobType::kURLRequest), 17 : job_type_(JobType::kURLRequest),
18 url_request_job_(std::move(url_request_job)), 18 url_request_job_(std::move(url_request_job)),
19 weak_factory_(this) {} 19 weak_factory_(this) {}
20 20
21 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper( 21 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper(LoaderCallback callback)
22 LoaderFactoryCallback callback)
23 : job_type_(JobType::kURLLoader), 22 : job_type_(JobType::kURLLoader),
24 loader_factory_callback_(std::move(callback)), 23 loader_callback_(std::move(callback)),
25 weak_factory_(this) { 24 weak_factory_(this) {
26 DCHECK(IsBrowserSideNavigationEnabled() && 25 DCHECK(IsBrowserSideNavigationEnabled() &&
27 base::CommandLine::ForCurrentProcess()->HasSwitch( 26 base::CommandLine::ForCurrentProcess()->HasSwitch(
28 switches::kEnableNetworkService)); 27 switches::kEnableNetworkService));
29 } 28 }
30 29
31 ServiceWorkerURLJobWrapper::~ServiceWorkerURLJobWrapper() {} 30 ServiceWorkerURLJobWrapper::~ServiceWorkerURLJobWrapper() {}
32 31
33 void ServiceWorkerURLJobWrapper::FallbackToNetwork() { 32 void ServiceWorkerURLJobWrapper::FallbackToNetwork() {
34 if (job_type_ == JobType::kURLLoader) { 33 if (job_type_ == JobType::kURLLoader) {
35 response_type_ = FALLBACK_TO_NETWORK; 34 response_type_ = FALLBACK_TO_NETWORK;
36 // This could be called multiple times in some cases because we simply 35 // This could be called multiple times in some cases because we simply
37 // call this synchronously here and don't wait for a separate async 36 // call this synchronously here and don't wait for a separate async
38 // StartRequest cue like what URLRequestJob case does. 37 // StartRequest cue like what URLRequestJob case does.
39 // TODO(kinuko): Make sure this is ok or we need to make this async. 38 // TODO(kinuko): Make sure this is ok or we need to make this async.
40 if (!loader_factory_callback_.is_null()) { 39 if (!loader_callback_.is_null()) {
41 std::move(loader_factory_callback_).Run(nullptr); 40 std::move(loader_callback_).Run(StartLoaderCallback());
42 } 41 }
43 } else { 42 } else {
44 url_request_job_->FallbackToNetwork(); 43 url_request_job_->FallbackToNetwork();
45 } 44 }
46 } 45 }
47 46
48 void ServiceWorkerURLJobWrapper::FallbackToNetworkOrRenderer() { 47 void ServiceWorkerURLJobWrapper::FallbackToNetworkOrRenderer() {
49 if (job_type_ == JobType::kURLLoader) { 48 if (job_type_ == JobType::kURLLoader) {
50 // TODO(kinuko): Implement this. Now we always fallback to network. 49 // TODO(kinuko): Implement this. Now we always fallback to network.
51 FallbackToNetwork(); 50 FallbackToNetwork();
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 void ServiceWorkerURLJobWrapper::FailDueToLostController() { 96 void ServiceWorkerURLJobWrapper::FailDueToLostController() {
98 if (job_type_ == JobType::kURLLoader) { 97 if (job_type_ == JobType::kURLLoader) {
99 NOTIMPLEMENTED(); 98 NOTIMPLEMENTED();
100 } else { 99 } else {
101 url_request_job_->FailDueToLostController(); 100 url_request_job_->FailDueToLostController();
102 } 101 }
103 } 102 }
104 103
105 bool ServiceWorkerURLJobWrapper::WasCanceled() const { 104 bool ServiceWorkerURLJobWrapper::WasCanceled() const {
106 if (job_type_ == JobType::kURLLoader) { 105 if (job_type_ == JobType::kURLLoader) {
107 return loader_factory_callback_.is_null(); 106 return loader_callback_.is_null();
108 } else { 107 } else {
109 return !url_request_job_; 108 return !url_request_job_;
110 } 109 }
111 } 110 }
112 111
113 void ServiceWorkerURLJobWrapper::StartRequest() { 112 void ServiceWorkerURLJobWrapper::StartRequest() {
114 DCHECK_EQ(FORWARD_TO_SERVICE_WORKER, response_type_); 113 DCHECK_EQ(FORWARD_TO_SERVICE_WORKER, response_type_);
115 // TODO(kinuko): Implement. For now we just exercise async fall back path 114 // TODO(kinuko): Implement. For now we just exercise async fall back path
116 // to the network. 115 // to the network.
117 base::ThreadTaskRunnerHandle::Get()->PostTask( 116 base::ThreadTaskRunnerHandle::Get()->PostTask(
118 FROM_HERE, base::Bind(&ServiceWorkerURLJobWrapper::FallbackToNetwork, 117 FROM_HERE, base::Bind(&ServiceWorkerURLJobWrapper::FallbackToNetwork,
119 weak_factory_.GetWeakPtr())); 118 weak_factory_.GetWeakPtr()));
120 } 119 }
121 120
122 } // namespace content 121 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698