Get rid of URLLoaderFactory in browser-side case

content/network/url_loader_impl.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/network/url_loader_impl.h"
 
 #include "base/task_scheduler/post_task.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/time.h"
 #include "content/common/net_adapters.h"
@@ skipping 135 matching lines @@
         break;
     }
   }
 
   return base::MakeUnique<net::ElementsUploadDataStream>(
       std::move(element_readers), body->identifier());
 }
 
 }  // namespace
 
-URLLoaderImpl::URLLoaderImpl(
-    NetworkContext* context,
-    mojom::URLLoaderAssociatedRequest url_loader_request,
-    int32_t options,
-    const ResourceRequest& request,
-    mojom::URLLoaderClientPtr url_loader_client)
+URLLoaderImpl::URLLoaderImpl(NetworkContext* context,
+                             int32_t options,
+                             const ResourceRequest& request)
     : context_(context),
       options_(options),
       connected_(true),
-      binding_(this, std::move(url_loader_request)),
-      url_loader_client_(std::move(url_loader_client)),
+      binding_(this),
       writable_handle_watcher_(FROM_HERE,
                                mojo::SimpleWatcher::ArmingPolicy::MANUAL),
       peer_closed_handle_watcher_(FROM_HERE,
                                   mojo::SimpleWatcher::ArmingPolicy::MANUAL),
       weak_ptr_factory_(this) {
-  binding_.set_connection_error_handler(
-      base::Bind(&URLLoaderImpl::OnConnectionError, base::Unretained(this)));
-
   url_request_ = context_->url_request_context()->CreateRequest(
       GURL(request.url), net::DEFAULT_PRIORITY, this);
   url_request_->set_method(request.method);
 
   url_request_->set_first_party_for_cookies(request.first_party_for_cookies);
 
   const Referrer referrer(request.referrer, request.referrer_policy);
   Referrer::SetReferrerForRequest(url_request_.get(), referrer);
 
   net::HttpRequestHeaders headers;
   headers.AddHeadersFromString(request.headers);
   url_request_->SetExtraRequestHeaders(headers);
 
   // Resolve elements from request_body and prepare upload data.
   if (request.request_body.get()) {
     scoped_refptr<base::SequencedTaskRunner> task_runner =
         base::CreateSequencedTaskRunnerWithTraits(
             {base::MayBlock(), base::TaskPriority::USER_VISIBLE});
     url_request_->set_upload(
         CreateUploadDataStream(request.request_body.get(), task_runner.get()));
   }
 
   int load_flags = BuildLoadFlagsForRequest(request, false);
   url_request_->SetLoadFlags(load_flags);
-
-  url_request_->Start();
 }
 
 URLLoaderImpl::~URLLoaderImpl() {}
 
 void URLLoaderImpl::Cleanup() {
   // The associated network context is going away and we have to destroy
   // net::URLRequest hold by this loader.
   delete this;
 }
 
+void URLLoaderImpl::Start(mojom::URLLoaderAssociatedRequest url_loader_request,
+                          mojom::URLLoaderClientPtr url_loader_client) {
+  DCHECK(!url_loader_client_);
+  DCHECK(!binding_.is_bound());
+  DCHECK(url_request_);
+
+  binding_.Bind(std::move(url_loader_request));
+  binding_.set_connection_error_handler(
+      base::Bind(&URLLoaderImpl::OnConnectionError, base::Unretained(this)));
+
+  url_loader_client_ = std::move(url_loader_client);
+
+  url_request_->Start();
+}
+
 void URLLoaderImpl::FollowRedirect() {
   if (!url_request_) {
     NotifyCompleted(net::ERR_UNEXPECTED);
     return;
   }
 
   url_request_->FollowDeferredRedirect();
 }
 
 void URLLoaderImpl::SetPriority(net::RequestPriority priority,
@@ skipping 174 matching lines @@
   ReadMore();
 }
 
 void URLLoaderImpl::DeleteIfNeeded() {
   bool has_data_pipe = pending_write_.get() || response_body_stream_.is_valid();
   if (!connected_ && !has_data_pipe)
     delete this;
 }
 
 }  // namespace content