Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: content/browser/service_worker/service_worker_url_job_wrapper.cc

Issue 2919313004: Get rid of URLLoaderFactory in browser-side case (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_url_job_wrapper.h" 5 #include "content/browser/service_worker/service_worker_url_job_wrapper.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "content/browser/service_worker/service_worker_response_type.h" 8 #include "content/browser/service_worker/service_worker_response_type.h"
9 #include "content/public/browser/resource_request_info.h" 9 #include "content/public/browser/resource_request_info.h"
10 #include "content/public/common/browser_side_navigation_policy.h" 10 #include "content/public/common/browser_side_navigation_policy.h"
11 #include "content/public/common/content_switches.h" 11 #include "content/public/common/content_switches.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper( 15 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper(
16 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job) 16 base::WeakPtr<ServiceWorkerURLRequestJob> url_request_job)
17 : job_type_(JobType::kURLRequest), 17 : job_type_(JobType::kURLRequest),
18 url_request_job_(std::move(url_request_job)), 18 url_request_job_(std::move(url_request_job)),
19 weak_factory_(this) {} 19 weak_factory_(this) {}
20 20
21 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper( 21 ServiceWorkerURLJobWrapper::ServiceWorkerURLJobWrapper(
22 LoaderFactoryCallback callback) 22 URLLoaderCallback callback)
23 : job_type_(JobType::kURLLoader), 23 : job_type_(JobType::kURLLoader),
24 loader_factory_callback_(std::move(callback)), 24 loader_callback_(std::move(callback)),
25 weak_factory_(this) { 25 weak_factory_(this) {
26 DCHECK(IsBrowserSideNavigationEnabled() && 26 DCHECK(IsBrowserSideNavigationEnabled() &&
27 base::CommandLine::ForCurrentProcess()->HasSwitch( 27 base::CommandLine::ForCurrentProcess()->HasSwitch(
28 switches::kEnableNetworkService)); 28 switches::kEnableNetworkService));
29 } 29 }
30 30
31 ServiceWorkerURLJobWrapper::~ServiceWorkerURLJobWrapper() {} 31 ServiceWorkerURLJobWrapper::~ServiceWorkerURLJobWrapper() {}
32 32
33 void ServiceWorkerURLJobWrapper::FallbackToNetwork() { 33 void ServiceWorkerURLJobWrapper::FallbackToNetwork() {
34 if (job_type_ == JobType::kURLLoader) { 34 if (job_type_ == JobType::kURLLoader) {
35 response_type_ = FALLBACK_TO_NETWORK; 35 response_type_ = FALLBACK_TO_NETWORK;
36 // This could be called multiple times in some cases because we simply 36 // This could be called multiple times in some cases because we simply
37 // call this synchronously here and don't wait for a separate async 37 // call this synchronously here and don't wait for a separate async
38 // StartRequest cue like what URLRequestJob case does. 38 // StartRequest cue like what URLRequestJob case does.
39 // TODO(kinuko): Make sure this is ok or we need to make this async. 39 // TODO(kinuko): Make sure this is ok or we need to make this async.
40 if (!loader_factory_callback_.is_null()) { 40 if (!loader_callback_.is_null()) {
41 std::move(loader_factory_callback_).Run(nullptr); 41 std::move(loader_callback_).Run(nullptr);
42 } 42 }
43 } else { 43 } else {
44 url_request_job_->FallbackToNetwork(); 44 url_request_job_->FallbackToNetwork();
45 } 45 }
46 } 46 }
47 47
48 void ServiceWorkerURLJobWrapper::FallbackToNetworkOrRenderer() { 48 void ServiceWorkerURLJobWrapper::FallbackToNetworkOrRenderer() {
49 if (job_type_ == JobType::kURLLoader) { 49 if (job_type_ == JobType::kURLLoader) {
50 // TODO(kinuko): Implement this. Now we always fallback to network. 50 // TODO(kinuko): Implement this. Now we always fallback to network.
51 FallbackToNetwork(); 51 FallbackToNetwork();
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 void ServiceWorkerURLJobWrapper::FailDueToLostController() { 97 void ServiceWorkerURLJobWrapper::FailDueToLostController() {
98 if (job_type_ == JobType::kURLLoader) { 98 if (job_type_ == JobType::kURLLoader) {
99 NOTIMPLEMENTED(); 99 NOTIMPLEMENTED();
100 } else { 100 } else {
101 url_request_job_->FailDueToLostController(); 101 url_request_job_->FailDueToLostController();
102 } 102 }
103 } 103 }
104 104
105 bool ServiceWorkerURLJobWrapper::WasCanceled() const { 105 bool ServiceWorkerURLJobWrapper::WasCanceled() const {
106 if (job_type_ == JobType::kURLLoader) { 106 if (job_type_ == JobType::kURLLoader) {
107 return loader_factory_callback_.is_null(); 107 return loader_callback_.is_null();
108 } else { 108 } else {
109 return !url_request_job_; 109 return !url_request_job_;
110 } 110 }
111 } 111 }
112 112
113 void ServiceWorkerURLJobWrapper::StartRequest() { 113 void ServiceWorkerURLJobWrapper::StartRequest() {
114 DCHECK_EQ(FORWARD_TO_SERVICE_WORKER, response_type_); 114 DCHECK_EQ(FORWARD_TO_SERVICE_WORKER, response_type_);
115 // TODO(kinuko): Implement. For now we just exercise async fall back path 115 // TODO(kinuko): Implement. For now we just exercise async fall back path
116 // to the network. 116 // to the network.
117 base::ThreadTaskRunnerHandle::Get()->PostTask( 117 base::ThreadTaskRunnerHandle::Get()->PostTask(
118 FROM_HERE, base::Bind(&ServiceWorkerURLJobWrapper::FallbackToNetwork, 118 FROM_HERE, base::Bind(&ServiceWorkerURLJobWrapper::FallbackToNetwork,
119 weak_factory_.GetWeakPtr())); 119 weak_factory_.GetWeakPtr()));
120 } 120 }
121 121
122 } // namespace content 122 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698