Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2919293002: Make navigation support consistent with completion support (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov, mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -356 lines) Patch
D pkg/analyzer_plugin/lib/src/utilities/navigation.dart View 1 chunk +0 lines, -83 lines 0 comments Download
A + pkg/analyzer_plugin/lib/src/utilities/navigation/navigation.dart View 2 chunks +26 lines, -1 line 0 comments Download
D pkg/analyzer_plugin/lib/utilities/navigation.dart View 1 chunk +0 lines, -90 lines 0 comments Download
A + pkg/analyzer_plugin/lib/utilities/navigation/navigation.dart View 4 chunks +49 lines, -27 lines 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/navigation/navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer_plugin/test/src/utilities/navigation/test_all.dart View 1 chunk +1 line, -5 lines 0 comments Download
D pkg/analyzer_plugin/test/src/utilities/navigation_test.dart View 1 chunk +0 lines, -127 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/test_all.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/utilities/navigation_test.dart View 4 chunks +30 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-04 15:59:00 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-04 19:20:38 UTC) #3
mfairhurst
LGTM too
3 years, 6 months ago (2017-06-05 19:05:48 UTC) #4
Brian Wilkerson
3 years, 6 months ago (2017-06-05 19:33:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
691cc1b57af17277c7cc12daae2e39dd406614ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698