Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: services/preferences/tracked/pref_hash_store_impl.cc

Issue 2919253002: Don't move raw pointers in services (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | services/ui/public/cpp/bitmap/child_shared_bitmap_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/preferences/tracked/pref_hash_store_impl.cc
diff --git a/services/preferences/tracked/pref_hash_store_impl.cc b/services/preferences/tracked/pref_hash_store_impl.cc
index 522b013c5bc1cadaecd1a17ec470ff6e35207267..f0cfd3196855a75d20fd522ed4fe8137a8b33f19 100644
--- a/services/preferences/tracked/pref_hash_store_impl.cc
+++ b/services/preferences/tracked/pref_hash_store_impl.cc
@@ -90,7 +90,7 @@ PrefHashStoreImpl::~PrefHashStoreImpl() {}
std::unique_ptr<PrefHashStoreTransaction> PrefHashStoreImpl::BeginTransaction(
HashStoreContents* storage) {
return std::unique_ptr<PrefHashStoreTransaction>(
- new PrefHashStoreTransactionImpl(this, std::move(storage)));
+ new PrefHashStoreTransactionImpl(this, storage));
}
std::string PrefHashStoreImpl::ComputeMac(const std::string& path,
@@ -126,7 +126,7 @@ PrefHashStoreImpl::PrefHashStoreTransactionImpl::PrefHashStoreTransactionImpl(
PrefHashStoreImpl* outer,
HashStoreContents* storage)
: outer_(outer),
- contents_(std::move(storage)),
+ contents_(storage),
super_mac_valid_(false),
super_mac_dirty_(false) {
if (!outer_->use_super_mac_)
« no previous file with comments | « no previous file | services/ui/public/cpp/bitmap/child_shared_bitmap_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698