Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2919233002: [Not for review] Tests for GC bug related to ScriptPromiseProperty.

Created:
3 years, 6 months ago by horo
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Not for review] Tests for GC bug related to ScriptPromiseProperty. This CL includes three tests for the GC bug in the following methods: BeforeInstallPromptEvent.userChoice() NavigatorBattery.getBattery() PresentationRequest.getAvailability() BUG=728013

Patch Set 1 #

Patch Set 2 : Add tests for GC bug of BeforeInstallPromptEvent and PresentationRequest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/app_banner/app-banner-event-gc.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/battery-status/multiple-promises.html View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/presentation/presentationrequest-gc.html View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-04 06:31:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919233002/1
3 years, 6 months ago (2017-06-04 06:31:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-04 07:44:58 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/471259)
3 years, 6 months ago (2017-06-04 07:44:59 UTC) #4
horo
The CQ bit was checked by horo@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-04 16:33:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919233002/20001
3 years, 6 months ago (2017-06-04 16:33:58 UTC) #6
horo
Description was changed from ========== [Not for review] GC bug in navigator.getBattery() BUG= ========== to ...
3 years, 6 months ago (2017-06-04 16:37:12 UTC) #7
horo
Description was changed from ========== [Not for review] Tests for GC bug related to ScriptPromiseProperty. ...
3 years, 6 months ago (2017-06-04 16:37:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-04 17:45:16 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-04 17:45:17 UTC) #10 
Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698