src/compiler/mips64/code-generator-mips64.cc - Issue 2919203002: [WASM] Eliminate SIMD boolean vector types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 2919203002: [WASM] Eliminate SIMD boolean vector types. (Closed)

Patch Set: Restore DCHECKs in AssembleMove/Swap now that we're back to 1 SIMD representation. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/mips64/code-generator-mips64.cc

diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc

index e904eaacaa660ca3482bafc79732598fac52f858..865b448688a7b6eef5c360f43f47740bfad4c710 100644

--- a/src/compiler/mips64/code-generator-mips64.cc

+++ b/src/compiler/mips64/code-generator-mips64.cc

@@ -2100,9 +2100,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(

i.InputSimd128Register(1));

break;

}

- case kMips64S32x4Select:

- case kMips64S16x8Select:

- case kMips64S8x16Select: {

+ case kMips64S128Select: {

CpuFeatureScope msa_scope(masm(), MIPS_SIMD);

DCHECK(i.OutputSimd128Register().is(i.InputSimd128Register(0)));

__ bsel_v(i.OutputSimd128Register(), i.InputSimd128Register(2),