Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/gpu/gpu_arc_video_decode_accelerator.h

Issue 2919193002: ArcBridge: Rename VideoAcceleratorService to VideoDecodeAccelerator. (Closed)
Patch Set: Address review comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/gpu/chrome_content_gpu_client.cc ('k') | chrome/gpu/gpu_arc_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gpu/gpu_arc_video_decode_accelerator.h
diff --git a/chrome/gpu/gpu_arc_video_service.h b/chrome/gpu/gpu_arc_video_decode_accelerator.h
similarity index 56%
rename from chrome/gpu/gpu_arc_video_service.h
rename to chrome/gpu/gpu_arc_video_decode_accelerator.h
index 08479066e979a780942db3fc758713850a6914f5..96d281b10a93a081bced087931280d515fd447f3 100644
--- a/chrome/gpu/gpu_arc_video_service.h
+++ b/chrome/gpu/gpu_arc_video_decode_accelerator.h
@@ -2,36 +2,38 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_GPU_GPU_ARC_VIDEO_SERVICE_H_
-#define CHROME_GPU_GPU_ARC_VIDEO_SERVICE_H_
+#ifndef CHROME_GPU_GPU_ARC_VIDEO_DECODE_ACCELERATOR_H_
+#define CHROME_GPU_GPU_ARC_VIDEO_DECODE_ACCELERATOR_H_
#include <memory>
#include <vector>
#include "base/files/scoped_file.h"
#include "base/macros.h"
-#include "chrome/gpu/arc_video_accelerator.h"
-#include "components/arc/common/video_accelerator.mojom.h"
+#include "chrome/gpu/arc_video_decode_accelerator.h"
+#include "components/arc/common/video_decode_accelerator.mojom.h"
#include "components/arc/video_accelerator/video_accelerator.h"
#include "gpu/command_buffer/service/gpu_preferences.h"
namespace chromeos {
namespace arc {
-// GpuArcVideoService manages life-cycle and IPC message translation for
-// ArcVideoAccelerator.
+// GpuArcVideoDecodeAccelerator manages life-cycle and IPC message translation
+// for ArcVideoDecodeAccelerator.
//
-// For each creation request from GpuArcVideoServiceHost, GpuArcVideoService
-// will create a new IPC channel.
-class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,
- public ArcVideoAccelerator::Client {
+// For each creation request from GpuArcVideoDecodeAcceleratorHost,
+// GpuArcVideoDecodeAccelerator will create a new IPC channel.
+class GpuArcVideoDecodeAccelerator
+ : public ::arc::mojom::VideoDecodeAccelerator,
+ public ArcVideoDecodeAccelerator::Client {
public:
- explicit GpuArcVideoService(const gpu::GpuPreferences& gpu_preferences);
- ~GpuArcVideoService() override;
+ explicit GpuArcVideoDecodeAccelerator(
+ const gpu::GpuPreferences& gpu_preferences);
+ ~GpuArcVideoDecodeAccelerator() override;
private:
- // ArcVideoAccelerator::Client implementation.
- void OnError(ArcVideoAccelerator::Result error) override;
+ // ArcVideoDecodeAccelerator::Client implementation.
+ void OnError(ArcVideoDecodeAccelerator::Result error) override;
void OnBufferDone(PortType port,
uint32_t index,
const BufferMetadata& metadata) override;
@@ -39,9 +41,9 @@ class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,
void OnResetDone() override;
void OnOutputFormatChanged(const VideoFormat& format) override;
- // ::arc::mojom::VideoAcceleratorService implementation.
- void Initialize(::arc::mojom::ArcVideoAcceleratorConfigPtr config,
- ::arc::mojom::VideoAcceleratorServiceClientPtr client,
+ // ::arc::mojom::VideoDecodeAccelerator implementation.
+ void Initialize(::arc::mojom::VideoDecodeAcceleratorConfigPtr config,
+ ::arc::mojom::VideoDecodeClientPtr client,
const InitializeCallback& callback) override;
void BindSharedMemory(::arc::mojom::PortType port,
uint32_t index,
@@ -62,16 +64,16 @@ class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,
base::ScopedFD UnwrapFdFromMojoHandle(mojo::ScopedHandle handle);
- base::ThreadChecker thread_checker_;
+ THREAD_CHECKER(thread_checker_);
gpu::GpuPreferences gpu_preferences_;
- std::unique_ptr<ArcVideoAccelerator> accelerator_;
- ::arc::mojom::VideoAcceleratorServiceClientPtr client_;
+ std::unique_ptr<ArcVideoDecodeAccelerator> accelerator_;
+ ::arc::mojom::VideoDecodeClientPtr client_;
- DISALLOW_COPY_AND_ASSIGN(GpuArcVideoService);
+ DISALLOW_COPY_AND_ASSIGN(GpuArcVideoDecodeAccelerator);
};
} // namespace arc
} // namespace chromeos
-#endif // CHROME_GPU_GPU_ARC_VIDEO_SERVICE_H_
+#endif // CHROME_GPU_GPU_ARC_VIDEO_DECODE_ACCELERATOR_H_
« no previous file with comments | « chrome/gpu/chrome_content_gpu_client.cc ('k') | chrome/gpu/gpu_arc_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698