Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: components/arc/common/video_decode_accelerator.mojom

Issue 2919193002: ArcBridge: Rename VideoAcceleratorService to VideoDecodeAccelerator. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/common/video_decode_accelerator.mojom
diff --git a/components/arc/common/video_accelerator.mojom b/components/arc/common/video_decode_accelerator.mojom
similarity index 81%
rename from components/arc/common/video_accelerator.mojom
rename to components/arc/common/video_decode_accelerator.mojom
index a329c335490e3ff16d2c9da89e5038637c7a73b3..1517584431cc19ead93793d628cb305eca740cd4 100644
--- a/components/arc/common/video_accelerator.mojom
+++ b/components/arc/common/video_decode_accelerator.mojom
@@ -3,7 +3,7 @@
// found in the LICENSE file.
// This file defined the mojo interface between Android and Chromium for video
-// decoding and encoding. See comments of ArcVideoAccelerator for more info.
+// decoding. See comments of VideoDecodeAccelerator for more info.
module arc.mojom;
@@ -38,12 +38,14 @@ struct VideoFormat {
uint32 crop_height;
};
-struct ArcVideoAcceleratorConfig {
+struct VideoDecodeAcceleratorConfig {
+ // Deprecated. This config struct is used for decoder only.
enum DeviceType {
Luis Héctor Chávez 2017/06/07 14:56:49 Can you add a "Deprecated" suffix?
Owen Lin 2017/06/08 02:32:50 Done.
DEVICE_ENCODER = 0,
DEVICE_DECODER = 1,
};
+ // Deprecated. Only decoder will be supported.
DeviceType device_type;
Luis Héctor Chávez 2017/06/07 14:56:49 same here, "_deprecated".
Owen Lin 2017/06/08 02:32:49 Done.
uint32 num_input_buffers;
uint32 input_pixel_format;
@@ -57,7 +59,7 @@ struct ArcVideoAcceleratorDmabufPlane {
// Next MinVersion: 4
// Deprecated method IDs: 2, 7
// Next method ID: 10
-interface VideoAcceleratorService {
+interface VideoDecodeAccelerator {
enum Result {
SUCCESS = 0,
ILLEGAL_STATE = 1,
@@ -68,8 +70,8 @@ interface VideoAcceleratorService {
};
[MinVersion=2]
- Initialize@8(ArcVideoAcceleratorConfig config,
- VideoAcceleratorServiceClient client) => (Result result);
+ Initialize@8(VideoDecodeAcceleratorConfig config,
+ VideoDecodeClient client) => (Result result);
BindSharedMemory@1(PortType port, uint32 index, handle ashmem_fd,
uint32 offset, uint32 length);
@@ -89,8 +91,8 @@ interface VideoAcceleratorService {
// Deprecated method IDs: 0
// Next method ID: 6
-interface VideoAcceleratorServiceClient {
- OnError@1(VideoAcceleratorService.Result error);
+interface VideoDecodeClient {
+ OnError@1(VideoDecodeAccelerator.Result error);
OnBufferDone@2(PortType port, uint32 index, BufferMetadata metadata);
« no previous file with comments | « components/arc/common/video_accelerator.typemap ('k') | components/arc/video_accelerator/video_accelerator_struct_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698