third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp - Issue 2919173002: Add DocumentMarker::kActiveSuggestion MarkerType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp

Issue 2919173002: Add DocumentMarker::kActiveSuggestion MarkerType (Closed)

Patch Set: Fix build errors Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/CompositionMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp

index 3db1f7ebd699ff6512ea7a232a377460cc2ea8a3..00b18024897b642cd5fc2b5248ca9233d5a04c65 100644

--- a/third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/CompositionMarkerTest.cpp

@@ -17,6 +17,13 @@ TEST_F(CompositionMarkerTest, MarkerType) {

EXPECT_EQ(DocumentMarker::kComposition, marker->GetType());

}

+TEST_F(CompositionMarkerTest, IsMarkerWithFormatting) {

+ DocumentMarker* marker = new CompositionMarker(

+ 0, 1, Color::kTransparent, CompositionMarker::Thickness::kThin,

+ Color::kTransparent);

+ EXPECT_TRUE(IsMarkerWithFormatting(*marker));

TEST_F(CompositionMarkerTest, ConstructorAndGetters) {

CompositionMarker* marker =

new CompositionMarker(0, 1, Color::kDarkGray,