Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2919163002: option to enable fasta scanner (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

option to enable fasta scanner * add cmdline option so that analyzer will use the fasta scanner * refactor handling of unterminated strings Use -DuseFastaScanner=true to use the fasta scanner rather than the analyzer scanner R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/32677b631f107ddf8dbbb49451bade798c0f02da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 5 chunks +18 lines, -35 lines 0 comments Download
M pkg/front_end/lib/src/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 6 months ago (2017-06-02 21:24:02 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-02 21:34:32 UTC) #3
danrubel
Committed patchset #1 (id:1) manually as 32677b631f107ddf8dbbb49451bade798c0f02da (presubmit successful).
3 years, 6 months ago (2017-06-05 18:13:15 UTC) #5
ahe
3 years, 6 months ago (2017-06-06 10:29:53 UTC) #6
Message was sent while issue was closed.
lgtm

Thank you!

Powered by Google App Engine
This is Rietveld 408576698