Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: src/store-buffer.cc

Issue 291913002: Relax assertion in StoreBuffer::FindPointersToNewSpaceInMapsRegion (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added assertion on map_eng Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/store-buffer.h" 5 #include "src/store-buffer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 443
444 void StoreBuffer::FindPointersToNewSpaceInMapsRegion( 444 void StoreBuffer::FindPointersToNewSpaceInMapsRegion(
445 Address start, 445 Address start,
446 Address end, 446 Address end,
447 ObjectSlotCallback slot_callback, 447 ObjectSlotCallback slot_callback,
448 bool clear_maps) { 448 bool clear_maps) {
449 Address map_aligned_start = MapStartAlign(start); 449 Address map_aligned_start = MapStartAlign(start);
450 Address map_aligned_end = MapEndAlign(end); 450 Address map_aligned_end = MapEndAlign(end);
451 451
452 ASSERT(map_aligned_start == start); 452 ASSERT(map_aligned_start == start);
453 ASSERT(map_aligned_end == end); 453 ASSERT(map_aligned_start <= map_aligned_end && map_aligned_end <= end);
454 454
455 FindPointersToNewSpaceInMaps(map_aligned_start, 455 FindPointersToNewSpaceInMaps(map_aligned_start,
456 map_aligned_end, 456 map_aligned_end,
457 slot_callback, 457 slot_callback,
458 clear_maps); 458 clear_maps);
459 } 459 }
460 460
461 461
462 void StoreBuffer::IteratePointersInStoreBuffer( 462 void StoreBuffer::IteratePointersInStoreBuffer(
463 ObjectSlotCallback slot_callback, 463 ObjectSlotCallback slot_callback,
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 } 611 }
612 old_buffer_is_sorted_ = false; 612 old_buffer_is_sorted_ = false;
613 old_buffer_is_filtered_ = false; 613 old_buffer_is_filtered_ = false;
614 *old_top_++ = reinterpret_cast<Address>(int_addr << kPointerSizeLog2); 614 *old_top_++ = reinterpret_cast<Address>(int_addr << kPointerSizeLog2);
615 ASSERT(old_top_ <= old_limit_); 615 ASSERT(old_top_ <= old_limit_);
616 } 616 }
617 heap_->isolate()->counters()->store_buffer_compactions()->Increment(); 617 heap_->isolate()->counters()->store_buffer_compactions()->Increment();
618 } 618 }
619 619
620 } } // namespace v8::internal 620 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698