Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/store-buffer.cc

Issue 291913002: Relax assertion in StoreBuffer::FindPointersToNewSpaceInMapsRegion (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "store-buffer.h" 5 #include "store-buffer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "v8.h" 9 #include "v8.h"
10 #include "counters.h" 10 #include "counters.h"
(...skipping 430 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 441
442 void StoreBuffer::FindPointersToNewSpaceInMapsRegion( 442 void StoreBuffer::FindPointersToNewSpaceInMapsRegion(
443 Address start, 443 Address start,
444 Address end, 444 Address end,
445 ObjectSlotCallback slot_callback, 445 ObjectSlotCallback slot_callback,
446 bool clear_maps) { 446 bool clear_maps) {
447 Address map_aligned_start = MapStartAlign(start); 447 Address map_aligned_start = MapStartAlign(start);
448 Address map_aligned_end = MapEndAlign(end); 448 Address map_aligned_end = MapEndAlign(end);
449 449
450 ASSERT(map_aligned_start == start); 450 ASSERT(map_aligned_start == start);
451 ASSERT(map_aligned_end == end);
Hannes Payer (out of office) 2014/05/20 05:49:49 can we change the assert to ASSERT(map_aligned_sta
452 451
453 FindPointersToNewSpaceInMaps(map_aligned_start, 452 FindPointersToNewSpaceInMaps(map_aligned_start,
454 map_aligned_end, 453 map_aligned_end,
455 slot_callback, 454 slot_callback,
456 clear_maps); 455 clear_maps);
457 } 456 }
458 457
459 458
460 void StoreBuffer::IteratePointersInStoreBuffer( 459 void StoreBuffer::IteratePointersInStoreBuffer(
461 ObjectSlotCallback slot_callback, 460 ObjectSlotCallback slot_callback,
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 } 608 }
610 old_buffer_is_sorted_ = false; 609 old_buffer_is_sorted_ = false;
611 old_buffer_is_filtered_ = false; 610 old_buffer_is_filtered_ = false;
612 *old_top_++ = reinterpret_cast<Address>(int_addr << kPointerSizeLog2); 611 *old_top_++ = reinterpret_cast<Address>(int_addr << kPointerSizeLog2);
613 ASSERT(old_top_ <= old_limit_); 612 ASSERT(old_top_ <= old_limit_);
614 } 613 }
615 heap_->isolate()->counters()->store_buffer_compactions()->Increment(); 614 heap_->isolate()->counters()->store_buffer_compactions()->Increment();
616 } 615 }
617 616
618 } } // namespace v8::internal 617 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698