Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2919003002: Revert "Use 'outline.dill' instead of 'platform.dill' in kernel isolate" (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use 'outline.dill' instead of 'platform.dill' in kernel isolate" This reverts commit 303ab0aa96da2dd530270b3beb8af1fba3881e1d. TBR=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ece423de173bcdb696809b26ee137d3d498bc44c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/lib/src/fasta/fasta.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Dmitry Stefantsov
Committed patchset #1 (id:1) manually as ece423de173bcdb696809b26ee137d3d498bc44c (presubmit successful).
3 years, 6 months ago (2017-06-02 10:19:34 UTC) #2
Dmitry Stefantsov
3 years, 6 months ago (2017-06-02 10:21:53 UTC) #3
Message was sent while issue was closed.
On 2017/06/02 10:19:34, Dmitry Stefantsov wrote:
> Committed patchset #1 (id:1) manually as
> ece423de173bcdb696809b26ee137d3d498bc44c (presubmit successful).

Apparently, switching to 'outline.dill' broke some tests.  I reverted and am
trying to fix it.

Powered by Google App Engine
This is Rietveld 408576698