[MD settings] fix layout in startup urls and search engines iron-lists

[MD settings] fix layout in startup urls and search engines iron-lists

This CL resolves a couple to-do items and lines up action menu icons in
onStartup and searchEngines iron-lists.

BUG=729263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[dschuyler, 2017-06-03 01:03:36]

Description was changed from

==========
[MD settings] fix layout in startup urls and search engines iron-lists

This CL resolves a couple to-do items and lines up action menu icons in
onStartup and searchEngines iron-lists.

BUG=729263
==========

to

==========
[MD settings] fix layout in startup urls and search engines iron-lists

This CL resolves a couple to-do items and lines up action menu icons in
onStartup and searchEngines iron-lists.

BUG=729263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-06-03 01:03:38]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-03 01:03:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-03 01:16:55]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-06-03 01:17:01]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-03 01:17:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-06-03 01:18:14]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[commit-bot: I haz the power, 2017-06-03 03:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 03:32:18]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hcarmona, 2017-06-05 22:35:24]

The scrollbar looks disconnected from the list

screen/zDyDP5DqtP7

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:35:
.fixed-height-container {
Consider moving this to a shared location and reusing?

[dschuyler, 2017-06-05 22:44:26]

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:35:
.fixed-height-container {
On 2017/06/05 22:35:24, hcarmona wrote:
> Consider moving this to a shared location and reusing?

I had considered it: The first nomeal would change from
--settings-row-min-height to --settings-row-two-line-min-height and the
coefficient 6 would need to be parameterized. I backed away from all that an
decided they were different enough to be different.

[hcarmona, 2017-06-05 23:40:37]

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/search_engines_page/search_engines_list.html
(right):

https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:35:
.fixed-height-container {
On 2017/06/05 22:44:26, dschuyler wrote:
> On 2017/06/05 22:35:24, hcarmona wrote:
> > Consider moving this to a shared location and reusing?
> 
> I had considered it: The first nomeal would change from
> --settings-row-min-height to --settings-row-two-line-min-height and the
> coefficient 6 would need to be parameterized. I backed away from all that an
> decided they were different enough to be different.

Sounds good, I didn't notice the difference when I first took a look.

[dschuyler, 2017-06-13 23:59:15]

On 2017/06/05 23:40:37, hcarmona wrote:
>
https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
> File
> chrome/browser/resources/settings/search_engines_page/search_engines_list.html
> (right):
> 
>
https://codereview.chromium.org/2918953004/diff/20001/chrome/browser/resource...
>
chrome/browser/resources/settings/search_engines_page/search_engines_list.html:35:
> .fixed-height-container {
> On 2017/06/05 22:44:26, dschuyler wrote:
> > On 2017/06/05 22:35:24, hcarmona wrote:
> > > Consider moving this to a shared location and reusing?
> > 
> > I had considered it: The first nomeal would change from
> > --settings-row-min-height to --settings-row-two-line-min-height and the
> > coefficient 6 would need to be parameterized. I backed away from all that an
> > decided they were different enough to be different.
> 
> Sounds good, I didn't notice the difference when I first took a look.

Alan decided the indented icons were fine. So the bug is a won't fix. Closing
this CL without landing it.