Fall back to X11 system tray icons if libappindicator is not available

Fall back to X11 system tray icons if libappindicator is not available.

This CL also splits out the code wrt to handling the GTK menu for the app indicator icon out of app_indicator_icon.cc in order to share code with gtk2_status_icon.cc

BUG=267195
TEST=Manual, see steps below.
1) Run chrome in a system which does not have libappindicator
2) Generate HTML 5 notifications via https://developer.cdn.mozilla.net/media/uploads/demos/e/l/elfoxero/c17223c414d8ddafb7808972b5617d9e/html5-notifications_1400214081_demo_package/index.html
3) Ensure that the bell icon shows up in the system tray and that clicking on the bell icon brings up the message center

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273337

[pkotwicz, 2014-05-27 23:02:09]

Elliot, PTAL

[Elliot Glaysher, 2014-05-27 23:25:51]

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.cc (right):

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.cc:65:
delegate()->OnClick();
To make sure I understand this, this fires when the user single clicks on the
status icon. And the ContextMenuRequested fires on right click?

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.h (right):

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.h:30: class
AppIndicatorIconFallback : public views::StatusIconLinux {
Please rename this to GtkStatusIcon or something. That we prefer AppIndicators
to StatusIcons on Unity doesn't really mean that everything is a fallback.

[pkotwicz, 2014-05-27 23:50:12]

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.cc (right):

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.cc:65:
delegate()->OnClick();
Yes, that's correct

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
File chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.h (right):

https://codereview.chromium.org/291893009/diff/80001/chrome/browser/ui/libgtk...
chrome/browser/ui/libgtk2ui/app_indicator_icon_fallback.h:30: class
AppIndicatorIconFallback : public views::StatusIconLinux {
Renamed to Gtk2StatusIcon

[Elliot Glaysher, 2014-05-27 23:52:54]

lgtm

[pkotwicz, 2014-05-28 16:58:21]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-05-28 16:59:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/291893009/120001

[commit-bot: I haz the power, 2014-05-28 20:14:20]

Change committed as 273337

[Mathieu, 2014-05-29 15:15:03]

A revert of this CL has been created in
https://codereview.chromium.org/304933002/ by mathp@chromium.org.

The reason for reverting is: Suspected ASAN leak on the bots. 

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....