ui/file_manager/gallery/js/background.js - Issue 291893006: Gallery.app: Remove old Gallery files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/gallery/js/background.js

Issue 291893006: Gallery.app: Remove old Gallery files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/file_manager/gallery/js/background.js

diff --git a/ui/file_manager/gallery/js/background.js b/ui/file_manager/gallery/js/background.js

index 61ea019d2f1723588bc96580eeea76886ec7484a..a3798821dbe5a49b155f6a9de6c93af2fc938e08 100644

--- a/ui/file_manager/gallery/js/background.js

+++ b/ui/file_manager/gallery/js/background.js

@@ -142,7 +142,12 @@ chrome.app.runtime.onLaunched.addListener(function(launchData) {

closePromise = appWindowPromise.then(function(appWindow) {

return new Promise(function(fulfill) {

appWindow.close();

- appWindow.onClosed.addListener(fulfill);

+ try {

+ appWindow.onClosed.addListener(fulfill);

+ } catch (error) {

+ // Sometimes it failes to addListener.

yoshiki 2014/05/23 06:16:13 The handler should be registered before closing it

hirono 2014/05/26 02:21:48 Done.

+ fulfill();

+ }

});

} else {

« no previous file with comments | « ui/file_manager/file_manager_resources.grd ('k') | ui/file_manager/gallery/manifest.json » ('j') | no next file with comments »