Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 291893006: Gallery.app: Remove old Gallery files. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Gallery.app: Remove old Gallery files. This CL removes old Gallery files and related codes. Along the way, the CL also fixes the file handler specification so that the Gallery can handle multiple selected video files. BUG=358698, 376240 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272863

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -12832 lines) Patch
M chrome/browser/chromeos/file_manager/app_id.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 2 chunks +0 lines, -29 lines 0 comments Download
D ui/file_manager/file_manager/foreground/css/gallery.css View 1 chunk +0 lines, -1381 lines 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/arrow_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/arrow_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/back_to_files.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/bubble_point.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/butterbar_close_button.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_crop.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_leftright.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_move.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_nwse.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_swne.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/cursor_updown.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_1up.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_1up_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_autofix.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_autofix_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_brightness.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_brightness_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_contrast.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_crop.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_crop_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_delete.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_delete_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_edit.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_edit_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_mosaic.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_mosaic_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_print.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_print_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_redo.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_redo_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_rotate.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_rotate_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_rotate_left_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_rotate_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_share.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_share_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_slideshow.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_slideshow_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_undo.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/icon_undo_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/slider_thumb.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/slideshow-end.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/slideshow-pause.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/2x/slideshow-play.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/arrow_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/arrow_right.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/back_to_files.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/bubble_point.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/butterbar_close_button.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_crop.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_leftright.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_move.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_nwse.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_swne.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/cursor_updown.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_1up.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_1up_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_autofix.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_autofix_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_brightness.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_brightness_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_contrast.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_crop.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_crop_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_delete.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_delete_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_edit.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_edit_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_mosaic.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_mosaic_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_print.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_print_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_redo.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_redo_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_rotate.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_rotate_left.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_rotate_left_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_rotate_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_share.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_share_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_slideshow.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_slideshow_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_undo.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/icon_undo_selected.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/slider_thumb.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/slideshow-end.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/slideshow-pause.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/gallery/slideshow-play.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +3 lines, -81 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 4 chunks +1 line, -109 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/commands.js View 1 chunk +0 lines, -455 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/exif_encoder.js View 1 chunk +0 lines, -569 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/filter.js View 1 chunk +0 lines, -612 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_adjust.js View 1 chunk +0 lines, -248 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_buffer.js View 1 chunk +0 lines, -184 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_editor.js View 1 chunk +0 lines, -1178 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_encoder.js View 1 chunk +0 lines, -228 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_transform.js View 1 chunk +0 lines, -493 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_util.js View 1 chunk +0 lines, -701 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/image_view.js View 1 chunk +0 lines, -1067 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/image_editor/viewport.js View 1 chunk +0 lines, -430 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/gallery.js View 1 chunk +0 lines, -884 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/gallery_item.js View 1 chunk +0 lines, -228 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/gallery_scripts.js View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/mosaic_mode.js View 1 chunk +0 lines, -2035 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/ribbon.js View 1 chunk +0 lines, -366 lines 0 comments Download
D ui/file_manager/file_manager/foreground/js/photo/slide_mode.js View 1 chunk +0 lines, -1344 lines 0 comments Download
D ui/file_manager/file_manager/gallery.html View 1 chunk +0 lines, -79 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 3 chunks +16 lines, -18 lines 0 comments Download
M ui/file_manager/gallery/js/background.js View 1 3 chunks +24 lines, -16 lines 0 comments Download
M ui/file_manager/gallery/manifest.json View 1 chunk +20 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-05-22 11:40:24 UTC) #1
yoshiki
https://codereview.chromium.org/291893006/diff/20001/ui/file_manager/gallery/js/background.js File ui/file_manager/gallery/js/background.js (right): https://codereview.chromium.org/291893006/diff/20001/ui/file_manager/gallery/js/background.js#newcode148 ui/file_manager/gallery/js/background.js:148: // Sometimes it failes to addListener. The handler should ...
6 years, 7 months ago (2014-05-23 06:16:13 UTC) #2
hirono
https://codereview.chromium.org/291893006/diff/20001/ui/file_manager/gallery/js/background.js File ui/file_manager/gallery/js/background.js (right): https://codereview.chromium.org/291893006/diff/20001/ui/file_manager/gallery/js/background.js#newcode148 ui/file_manager/gallery/js/background.js:148: // Sometimes it failes to addListener. On 2014/05/23 06:16:13, ...
6 years, 7 months ago (2014-05-26 02:21:47 UTC) #3
yoshiki
lgtm
6 years, 7 months ago (2014-05-26 04:15:42 UTC) #4
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 7 months ago (2014-05-26 04:17:05 UTC) #5
hirono
On 2014/05/26 04:15:42, yoshiki wrote: > lgtm Thank you!
6 years, 7 months ago (2014-05-26 04:17:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/291893006/40001
6 years, 7 months ago (2014-05-26 04:18:14 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 06:17:20 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-26 19:26:08 UTC) #9
Message was sent while issue was closed. 
Change committed as 272863

Powered by Google App Engine
This is Rietveld 408576698