Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 291893005: Fix an error in net/tools/tld_cleanup/PRESUBMIT.py. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Fix an error in net/tools/tld_cleanup/PRESUBMIT.py. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/tools/tld_cleanup/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-22 20:55:22 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-22 22:11:21 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-22 22:17:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/291893005/1
6 years, 7 months ago (2014-05-22 22:19:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 02:18:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 05:34:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31874)
6 years, 7 months ago (2014-05-23 05:34:54 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-23 05:41:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/291893005/1
6 years, 7 months ago (2014-05-23 05:42:57 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 10:31:12 UTC) #10
Message was sent while issue was closed.
Change committed as 272466

Powered by Google App Engine
This is Rietveld 408576698