Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2918923003: Revert "Use backend targets to run Kernel transformations in Fasta" (Closed)

Created:
3 years, 6 months ago by Dmitry Stefantsov
Modified:
3 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use backend targets to run Kernel transformations in Fasta" This reverts commit 8ff762067a9fd65513dcd711493d311791bf2774. TBR=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/0b424ca5d2b89961de478475ff5b7182e25efe47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -160 lines) Patch
M pkg/front_end/lib/kernel_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_target.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 6 chunks +12 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +21 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/shaker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/target/flutter.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 4 chunks +11 lines, -43 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 1 chunk +4 lines, -6 lines 0 comments Download
D pkg/kernel/lib/target/vm_fasta.dart View 1 chunk +0 lines, -44 lines 0 comments Download
M pkg/kernel/lib/target/vmcc.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/lib/target/vmreify.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/erasure.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/kernel/test/baseline_tester.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/test/interpreter/suite.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/test/reify/suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/tool/dartk.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Dmitry Stefantsov
Committed patchset #1 (id:1) manually as 0b424ca5d2b89961de478475ff5b7182e25efe47 (presubmit successful).
3 years, 6 months ago (2017-06-02 10:46:01 UTC) #2
ahe
3 years, 6 months ago (2017-06-02 11:05:06 UTC) #3
Message was sent while issue was closed. 
lgtm

:-(

Powered by Google App Engine
This is Rietveld 408576698