Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2918913003: Handle list and map literals (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -111 lines) Patch
M pkg/compiler/lib/src/elements/resolution_types.dart View 4 chunks +24 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 2 chunks +52 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 5 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/types.dart View 3 chunks +19 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 3 chunks +7 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 2 6 chunks +13 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_variable_occurrence_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-06-02 12:40:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2918913003/diff/20001/pkg/compiler/lib/src/ssa/locals_handler.dart File pkg/compiler/lib/src/ssa/locals_handler.dart (right): https://codereview.chromium.org/2918913003/diff/20001/pkg/compiler/lib/src/ssa/locals_handler.dart#newcode100 pkg/compiler/lib/src/ssa/locals_handler.dart:100: //type = type.substByContext(contextClass.asInstanceOf(typeContext)); delete old code? also below?
3 years, 6 months ago (2017-06-02 18:09:23 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 8acac25e5e674d37c9f013901ea6803be3ba6512 (presubmit successful).
3 years, 6 months ago (2017-06-02 18:53:26 UTC) #5
Johnni Winther
3 years, 6 months ago (2017-06-02 18:53:46 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2918913003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/locals_handler.dart (right):

https://codereview.chromium.org/2918913003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/locals_handler.dart:100: //type =
type.substByContext(contextClass.asInstanceOf(typeContext));
On 2017/06/02 18:09:23, Siggi Cherem (dart-lang) wrote:
> delete old code? also below?

Done.

Powered by Google App Engine
This is Rietveld 408576698