content/renderer/render_view_browsertest.cc - Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame (Closed)

Patch Set: s/kFavIcon/kFavicon/g (as suggested in CR feedback from pkotwicz@). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 868a9c166e67a54c1b4ddc0e5d0a822b531416a6..e5ca79656a9657d9035cbfd5af20dcdc6f377f36 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -1911,7 +1911,7 @@ TEST_F(RenderViewImplTest, SendFaviconURLUpdateEvent) {

"</head>"

"</html>");

EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(

- ViewHostMsg_UpdateFaviconURL::ID));

+ FrameHostMsg_UpdateFaviconURL::ID));

render_thread_->sink().ClearMessages();

// An event should not be sent if no favicon url exists. This is an assumption

@@ -1921,7 +1921,7 @@ TEST_F(RenderViewImplTest, SendFaviconURLUpdateEvent) {

"</head>"

"</html>");

EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching(

- ViewHostMsg_UpdateFaviconURL::ID));

+ FrameHostMsg_UpdateFaviconURL::ID));

}

TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »