content/public/common/favicon_url.cc - Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/favicon_url.cc

Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame (Closed)

Patch Set: s/kFavIcon/kFavicon/g (as suggested in CR feedback from pkotwicz@). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/favicon_url.cc

diff --git a/content/public/common/favicon_url.cc b/content/public/common/favicon_url.cc

index 80debff64ba5f75e9a94c14175381268ab41a8b6..d727838f4c009a5e45778285d63cd643e53db90d 100644

--- a/content/public/common/favicon_url.cc

+++ b/content/public/common/favicon_url.cc

@@ -6,9 +6,7 @@

namespace content {

-FaviconURL::FaviconURL()

- : icon_type(INVALID_ICON) {

+FaviconURL::FaviconURL() : icon_type(IconType::kInvalid) {}

FaviconURL::FaviconURL(const GURL& url,

IconType type,

« no previous file with comments | « content/public/common/favicon_url.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »