chrome/browser/extensions/favicon_downloader.cc - Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/favicon_downloader.cc

Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame (Closed)

Patch Set: s/kFavIcon/kFavicon/g (as suggested in CR feedback from pkotwicz@). Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/favicon_downloader.cc

diff --git a/chrome/browser/extensions/favicon_downloader.cc b/chrome/browser/extensions/favicon_downloader.cc

index fa6f2ad0e63cbbabaefa22e602302aefaed2c7dc..c1dc3ebe4ec58c84528fc56cf62a47ebb8451974 100644

--- a/chrome/browser/extensions/favicon_downloader.cc

+++ b/chrome/browser/extensions/favicon_downloader.cc

@@ -73,7 +73,7 @@ void FaviconDownloader::FetchIcons(

for (std::vector<content::FaviconURL>::const_iterator it =

favicon_urls.begin();

it != favicon_urls.end(); ++it) {

- if (it->icon_type != content::FaviconURL::INVALID_ICON)

+ if (it->icon_type != content::FaviconURL::IconType::kInvalid)

urls.push_back(it->icon_url);

}

FetchIcons(urls);