third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame (Closed)

Patch Set: Addressed CR feedback from avi@ Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index a72b4e1fa0eb23f7fdd7fd098622f3a40d497e1c..46e9e4ce05a6c1e1c2faa5b97cae8276300cedc2 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -87,11 +87,6 @@ void WebRemoteFrameImpl::SetName(const WebString&) {

NOTREACHED();

}

-WebVector<WebIconURL> WebRemoteFrameImpl::IconURLs(int icon_types_mask) const {

- NOTREACHED();

- return WebVector<WebIconURL>();

WebSize WebRemoteFrameImpl::GetScrollOffset() const {

NOTREACHED();

return WebSize();