Chromium Code Reviews| Index: content/public/common/favicon_url.h |
| diff --git a/content/public/common/favicon_url.h b/content/public/common/favicon_url.h |
| index 349fc8785ae43001126f51ad39024e25d911e21a..9c52cfce63b0c1ec818b075560df9e12bc237204 100644 |
| --- a/content/public/common/favicon_url.h |
| +++ b/content/public/common/favicon_url.h |
| @@ -17,11 +17,12 @@ namespace content { |
| struct CONTENT_EXPORT FaviconURL { |
| // The icon type in a page. The definition must be same as |
| // favicon_base::IconType. |
| - enum IconType { |
| - INVALID_ICON = 0x0, |
| - FAVICON = 1 << 0, |
| - TOUCH_ICON = 1 << 1, |
| - TOUCH_PRECOMPOSED_ICON = 1 << 2 |
|
Avi (use Gerrit)
2017/06/06 23:10:04
They were using bitmasks, but never combining them
Łukasz Anforowicz
2017/06/06 23:25:36
Right - I was rather confused by this: initially I
|
| + enum class IconType { |
| + kInvalid, |
| + kFavIcon, |
| + kTouchIcon, |
| + kTouchPrecomposedIcon, |
| + kMax = kTouchPrecomposedIcon, |
| }; |
| FaviconURL(); |