content/browser/web_contents/web_contents_impl.h - Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2918903002: Move IconURLs method from WebFrame to WebLocalFrame (Closed)

Patch Set: Simplify unit test changes to avoid UaF from previous patchset. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 3b589327633783567dc7972421fabc7545e49d34..6202a0b97da65756c9eda469e602baa271d29f38 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -1119,7 +1119,7 @@ class CONTENT_EXPORT WebContentsImpl

void OnBrowserPluginMessage(RenderFrameHost* render_frame_host,

const IPC::Message& message);

#endif // BUILDFLAG(ENABLE_PLUGINS)

- void OnUpdateFaviconURL(RenderViewHostImpl* source,

+ void OnUpdateFaviconURL(RenderFrameHostImpl* source,

const std::vector<FaviconURL>& candidates);

void OnFirstVisuallyNonEmptyPaint(RenderViewHostImpl* source);

void OnShowValidationMessage(RenderViewHostImpl* source,