Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/disk_cache/simple/simple_experiment.cc

Issue 2918893002: evict larger entries first (Closed)
Patch Set: update experiment param Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_experiment.cc
diff --git a/net/disk_cache/simple/simple_experiment.cc b/net/disk_cache/simple/simple_experiment.cc
index 38ea589322f97df405f9b48bcaa349510847ce52..e33d81bb5493aece500b9ee4ec8e6160374143f0 100644
--- a/net/disk_cache/simple/simple_experiment.cc
+++ b/net/disk_cache/simple/simple_experiment.cc
@@ -15,10 +15,26 @@ namespace disk_cache {
const base::Feature kSimpleSizeExperiment = {"SimpleSizeExperiment",
base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kSimpleCacheEvictionWithSize = {
+ "SimpleCacheEvictionWithSize", base::FEATURE_DISABLED_BY_DEFAULT};
+
const char kSizeMultiplierParam[] = "SizeMultiplier";
namespace {
+// Updates experiment if the experiment is active.
+void CheckForEvictionWithSizeExperiment(
+ disk_cache::SimpleExperiment* experiment) {
+ if (experiment->type != disk_cache::SimpleExperimentType::NONE)
+ return;
+
+ if (base::FeatureList::GetFieldTrial(kSimpleCacheEvictionWithSize)) {
+ experiment->type = SimpleExperimentType::EVICT_WITH_SIZE;
+ experiment->param =
+ base::FeatureList::IsEnabled(kSimpleCacheEvictionWithSize) ? 1 : 0;
+ }
+}
+
// Returns true if the experiment is found and properly defined.
bool CheckForSimpleSizeExperiment(disk_cache::SimpleExperiment* experiment) {
DCHECK_EQ(disk_cache::SimpleExperimentType::NONE, experiment->type);
@@ -58,6 +74,7 @@ SimpleExperiment GetSimpleExperiment(net::CacheType cache_type) {
return experiment;
CheckForSimpleSizeExperiment(&experiment);
+ CheckForEvictionWithSizeExperiment(&experiment);
return experiment;
}

Powered by Google App Engine
This is Rietveld 408576698