evict larger entries first

net/disk_cache/simple/simple_experiment_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/simple/simple_experiment.h"
 
 #include <map>
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 31 matching lines @@
           kTrialName, kGroupName, params);
     }
 
     std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
     feature_list->RegisterFieldTrialOverride(
         kSimpleSizeExperiment.name, base::FeatureList::OVERRIDE_ENABLE_FEATURE,
         trial.get());
     scoped_feature_list_.InitWithFeatureList(std::move(feature_list));
   }
 
+  void ConfigureEvictWithSizeTrial(bool enabled,
+                                   base::Optional<uint32_t> param) {
+    const std::string kTrialName = "EvictWithSizeTrial";
+    const std::string kGroupName = "GroupFoo";  // Value not used
+
+    scoped_refptr<base::FieldTrial> trial =
+        base::FieldTrialList::CreateFieldTrial(kTrialName, kGroupName);
+
+    if (param) {
+      std::map<std::string, std::string> params;
+      params[kSizeEvictionParam] = base::UintToString(param.value());
+      base::FieldTrialParamAssociator::GetInstance()->AssociateFieldTrialParams(
+          kTrialName, kGroupName, params);
+    }
+
+    std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
+    feature_list->RegisterFieldTrialOverride(
+        kSimpleCacheEvictionWithSizeExperiment.name,
+        base::FeatureList::OVERRIDE_ENABLE_FEATURE, trial.get());
+    scoped_feature_list_.InitWithFeatureList(std::move(feature_list));
+  }
+
   std::unique_ptr<base::FieldTrialList> field_trial_list_;
   base::test::ScopedFeatureList scoped_feature_list_;
 };
 
 TEST_F(SimpleExperimentTest, NoExperiment) {
   SimpleExperiment experiment = GetSimpleExperiment(net::DISK_CACHE);
   EXPECT_EQ(SimpleExperimentType::NONE, experiment.type);
   EXPECT_EQ(0u, experiment.param);
 }
 
@@ skipping 19 matching lines @@
 TEST_F(SimpleExperimentTest, SizeTrialProperlyConfiguredWrongCacheType) {
   const uint32_t kParam = 125u;
   base::test::ScopedFeatureList scoped_feature_list;
   ConfigureSizeFieldTrial(true, base::Optional<uint32_t>(kParam));
 
   SimpleExperiment experiment = GetSimpleExperiment(net::APP_CACHE);
   EXPECT_EQ(SimpleExperimentType::NONE, experiment.type);
   EXPECT_EQ(0u, experiment.param);
 }
 
+TEST_F(SimpleExperimentTest, EvictWithSizeMissingParam) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  ConfigureEvictWithSizeTrial(true, base::Optional<uint32_t>());
+
+  SimpleExperiment experiment = GetSimpleExperiment(net::DISK_CACHE);
+  EXPECT_EQ(SimpleExperimentType::NONE, experiment.type);
+  EXPECT_EQ(0u, experiment.param);
+}
+
+TEST_F(SimpleExperimentTest, EvictWithSizeProperlyConfigured) {
+  const uint32_t kParam = 1u;
+  base::test::ScopedFeatureList scoped_feature_list;
+  ConfigureEvictWithSizeTrial(true, base::Optional<uint32_t>(kParam));
+
+  SimpleExperiment experiment = GetSimpleExperiment(net::DISK_CACHE);
+  EXPECT_EQ(SimpleExperimentType::EVICT_WITH_SIZE, experiment.type);
+  EXPECT_EQ(kParam, experiment.param);
+}
+
+TEST_F(SimpleExperimentTest, EvictWithSizeProperlyConfiguredWrongCacheType) {
+  const uint32_t kParam = 125u;
+  base::test::ScopedFeatureList scoped_feature_list;
+  ConfigureEvictWithSizeTrial(true, base::Optional<uint32_t>(kParam));
+
+  SimpleExperiment experiment = GetSimpleExperiment(net::APP_CACHE);
+  EXPECT_EQ(SimpleExperimentType::NONE, experiment.type);
+  EXPECT_EQ(0u, experiment.param);
+}
+
 }  // namespace disk_cache