Source/core/html/HTMLVideoElement.h - Issue 291873002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLVideoElement.h

Issue 291873002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: updated as per the review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLVideoElement.h

diff --git a/Source/core/html/HTMLVideoElement.h b/Source/core/html/HTMLVideoElement.h

index 12f2a6fe8f2c71b9e097180c7f5573ba42cc7afd..a52f4f21ddb657eab045d1f8c1ae5fa09d1cc949 100644

--- a/Source/core/html/HTMLVideoElement.h

+++ b/Source/core/html/HTMLVideoElement.h

@@ -84,7 +84,7 @@ private:

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;

virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;

virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) OVERRIDE;

- virtual bool hasVideo() const OVERRIDE { return player() && player()->hasVideo(); }

+ virtual bool hasVideo() const OVERRIDE { return webMediaPlayer() && webMediaPlayer()->hasVideo(); }

bool supportsFullscreen() const;

virtual bool isURLAttribute(const Attribute&) const OVERRIDE;

virtual const AtomicString imageSourceURL() const OVERRIDE;

« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/core/html/HTMLVideoElement.cpp » ('j') | no next file with comments »