src/isolate.cc - Issue 2918703002: Localize counter class member functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 2918703002: Localize counter class member functions. (Closed)

Patch Set: Remove need for mutex to initialize counters. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index f2564f9f3eb83cfb1042b2d583b1295c03e88332..481e852447257e234d1fbaadb0b3a5b79c4a71ab 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -2637,11 +2637,7 @@ bool Isolate::PropagatePendingExceptionToExternalTryCatch() {

return true;

}

-static base::LazyMutex initialize_counters_mutex = LAZY_MUTEX_INITIALIZER;

bool Isolate::InitializeCounters() {

- if (counters_ != nullptr) return false;

- base::LockGuard<base::Mutex> guard(initialize_counters_mutex.Pointer());

if (counters_ != nullptr) return false;

counters_shared_ = std::make_shared<Counters>(this);

counters_ = counters_shared_.get();