Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: src/isolate.cc

Issue 2918703002: Localize counter class member functions. (Closed)
Patch Set: Move ctors back to private. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | test/unittests/counters-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index b563433aa3f86c06c52fd673a19917990107cf05..69c84e82e52bd13e5d4c2dcc6c3a984b17da7e4b 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -2290,7 +2290,6 @@ Isolate::Isolate(bool enable_serializer)
runtime_profiler_(NULL),
compilation_cache_(NULL),
logger_(NULL),
- stats_table_(NULL),
load_stub_cache_(NULL),
store_stub_cache_(NULL),
code_aging_helper_(NULL),
@@ -2544,7 +2543,6 @@ Isolate::~Isolate() {
store_stub_cache_ = NULL;
delete code_aging_helper_;
code_aging_helper_ = NULL;
- stats_table_ = NULL;
delete materialized_object_store_;
materialized_object_store_ = NULL;
@@ -2852,16 +2850,6 @@ bool Isolate::Init(Deserializer* des) {
}
-// Initialized lazily to allow early
-// v8::V8::SetAddHistogramSampleFunction calls.
-StatsTable* Isolate::stats_table() {
- if (stats_table_ != nullptr) return stats_table_;
- InitializeCounters();
- stats_table_ = counters_shared_->stats_table();
- return stats_table_;
-}
-
-
void Isolate::Enter() {
Isolate* current_isolate = NULL;
PerIsolateThreadData* current_data = CurrentPerIsolateThreadData();
« no previous file with comments | « src/isolate.h ('k') | test/unittests/counters-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698