Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Issue 2918663006: Additional tests for ClassHierarchy.forEachOverridePair(). (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment out the debug code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -14 lines) Patch
M pkg/kernel/test/class_hierarchy_test.dart View 1 4 chunks +121 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 6 months ago (2017-06-01 17:37:14 UTC) #1
Paul Berry
https://codereview.chromium.org/2918663006/diff/1/pkg/kernel/test/class_hierarchy_test.dart File pkg/kernel/test/class_hierarchy_test.dart (right): https://codereview.chromium.org/2918663006/diff/1/pkg/kernel/test/class_hierarchy_test.dart#newcode801 pkg/kernel/test/class_hierarchy_test.dart:801: if (actualText != expectedText) { Did you uncomment this ...
3 years, 6 months ago (2017-06-01 21:43:46 UTC) #2
scheglov
PTAL https://codereview.chromium.org/2918663006/diff/1/pkg/kernel/test/class_hierarchy_test.dart File pkg/kernel/test/class_hierarchy_test.dart (right): https://codereview.chromium.org/2918663006/diff/1/pkg/kernel/test/class_hierarchy_test.dart#newcode801 pkg/kernel/test/class_hierarchy_test.dart:801: if (actualText != expectedText) { On 2017/06/01 21:43:46, ...
3 years, 6 months ago (2017-06-01 21:45:25 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-06-01 21:50:22 UTC) #4
scheglov
3 years, 6 months ago (2017-06-01 21:51:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d91ba0585940ae64097f735bf7c46a6a91795bf6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698