Issue 2918653005: update .status file once more: move dartk condition to the _kernel.status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2918653005: update .status file once more: move dartk condition to the _kernel.status file. (Closed)

Created:
3 years, 6 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 6 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

update .status file once more: move dartk condition to the _kernel.status file. R=ahe@google.com, efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/7affe8f0e545626d41716fc8c9aac97f4e7bdd25

Patch Set 1 #

Total comments: 1

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	tests/language/language_kernel.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

Committed patchset #1 (id:1) manually as 7affe8f0e545626d41716fc8c9aac97f4e7bdd25 (presubmit successful).

3 years, 6 months ago (2017-06-01 18:18:19 UTC) #4

ahe

3 years, 6 months ago (2017-06-02 12:36:36 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2918653005/diff/1/tests/language/language_ker...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2918653005/diff/1/tests/language/language_ker...
tests/language/language_kernel.status:27: const_native_factory_test/01:
MissingCompileTimeError # Issue 29763
You might want to move this down to the triaged section below and make the
comment look like this:

# Fasta bug: Issue 29763

Then it will get categorized correctly by go/awky.

And I'm not at all being nitpicking so that you have to make another CL with
this status file update ;-P

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages