content/renderer/fetchers/resource_fetcher_impl.cc - Issue 2918653004: Remove dup'ed code for RequestorOrigin and FirstPartyCookie

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2918653004: Remove dup'ed code for RequestorOrigin and FirstPartyCookie (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/fetchers/resource_fetcher_impl.cc

diff --git a/content/renderer/fetchers/resource_fetcher_impl.cc b/content/renderer/fetchers/resource_fetcher_impl.cc

index f0f62b6ca3d50aba1e4d1b9e7db39ad27b0005d4..c83f04ca4df44fb5b3ecc3a044f4724e49f224c6 100644

--- a/content/renderer/fetchers/resource_fetcher_impl.cc

+++ b/content/renderer/fetchers/resource_fetcher_impl.cc

@@ -183,6 +183,7 @@ void ResourceFetcherImpl::Start(

request_.SetRequestContext(request_context);

request_.SetFirstPartyForCookies(frame->GetDocument().FirstPartyForCookies());

+ request_.SetRequestorOrigin(frame->GetDocument().GetSecurityOrigin());

kinuko 2017/06/07 02:00:48 I think this was missing before this change (i.e.

request_.AddHTTPOriginIfNeeded(blink::WebSecurityOrigin::CreateUnique());

client_.reset(new ClientImpl(this, callback));