Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 291863003: Replace CursorList with RefVector<CursorData>. (Closed)

Created:
6 years, 7 months ago by andersr
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, Mikhail, leviw+renderwatch, blink-reviews-events_chromium.org, dglazkov+blink, abarth-chromium, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, blink-reviews-wtf_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Replace CursorList with RefVector<CursorData>. We recently added a template in wtf/ for any case where we want to store a Vector in a RefPtr. The list of CursorData objects should be implemented by re-using that template, rather than with its own special class which does exactly the same thing. I added RefVector::at, because it's used by existing CursorList-code. (See CSSComputedStyleDeclaration:1875). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -71 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResourceLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/rendering/style/CursorList.h View 1 chunk +0 lines, -62 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/RefVector.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
andersr
6 years, 7 months ago (2014-05-19 09:47:31 UTC) #1
esprehn
lgtm
6 years, 7 months ago (2014-05-19 22:07:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/291863003/1
6 years, 7 months ago (2014-05-19 22:08:01 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 23:35:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 23:47:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/5709)
6 years, 7 months ago (2014-05-19 23:48:00 UTC) #6
Julien - ping for review
lgtm
6 years, 7 months ago (2014-05-20 11:14:11 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 11:31:08 UTC) #8
Message was sent while issue was closed.
Change committed as 174367

Powered by Google App Engine
This is Rietveld 408576698