Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart

Issue 2918623004: Use backend targets to run Kernel transformations in Fasta (Closed)
Patch Set: Remove some overrides of performModularTransformationsOnProgram Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
index 88cea4b0b140dcd2ade6ba3506206afe400f63ec..af37585f0105663c47fed5115d5833631ec21397 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart
@@ -654,24 +654,9 @@ class KernelTarget extends TargetImplementation {
/// Run all transformations that are needed when building a program for the
/// first time.
void runBuildTransformations() {
- transformMixinApplications();
- otherTransformations();
- }
-
- void transformMixinApplications() {
- mix.transformLibraries(backendTarget, loader.coreTypes, loader.libraries);
- ticker.logMs("Transformed mixin applications");
- }
-
- void otherTransformations() {
- // TODO(ahe): Don't generate type variables in the first place.
- if (!strongMode) {
- _program.accept(new Erasure());
- ticker.logMs("Erased type variables in generic methods");
- }
- // TODO(kmillikin): Make this run on a per-method basis.
- transformAsync.transformLibraries(loader.coreTypes, loader.libraries);
- ticker.logMs("Transformed async methods");
+ backendTarget.performModularTransformationsOnLibraries(
+ loader.coreTypes, loader.libraries,
+ logger: (String msg) => ticker.logMs(msg));
ahe 2017/06/01 11:44:54 Nice touch keeping the logging!
}
void verify() {

Powered by Google App Engine
This is Rietveld 408576698