Use backend targets to run Kernel transformations in Fasta

Use backend targets to run Kernel transformations in Fasta

R=ahe@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8ff762067a9fd65513dcd711493d311791bf2774

[Dmitry Stefantsov, 2017-06-01 11:16:01]

dmitryas@google.com changed reviewers:
+ ahe@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-06-01 11:16:04]

The intent of this CL is to put all target-specific transformations into backend
targets.  Here are some details:

* "performModularTransformations" transformed into two methods:
"performModularTransformationsOnProgram" and
"performModularTransformationsOnLibraries" that should do essentially the same
job if called with "program" and "program.libraries" respectively, but the
latter allows to pass a subset of the program libraries

* A new subclass of "Target" class is created, because "VmTarget" differs
slightly in how it performs transformations from what is implemented in
"KernelTarget" currently. The new class, "VmFastaTarget", mimics transformations
that were invoked in "KernelTarget".

* A "TargetFlags" instance now can be passed to the constructor of "DillTarget",
because the latter creates an instance of a backend target class and should pass
the flags to it. "VmFastaTarget" learns "strongMode" flag from it to (not)
perform erasure.

[ahe, 2017-06-01 11:44:55]

lgtm

Sweet!

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right):

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:659: logger: (String msg)
=> ticker.logMs(msg));
Nice touch keeping the logging!

[ahe, 2017-06-01 11:46:10]

I think there may be a few conflicts with this CL:
https://codereview.chromium.org/2918593003/

[Dmitry Stefantsov, 2017-06-01 12:36:38]

On 2017/06/01 11:46:10, ahe wrote:
> I think there may be a few conflicts with this CL:
> https://codereview.chromium.org/2918593003/

Thank you for the links, Peter!

Hi Konstantin,

I don't mind to wait a little and then adopt this CL to the changes. Also, I'd
appreciate if you take a look at this CL and let me know what you think.

Thanks!

[scheglov, 2017-06-01 14:08:26]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-01 14:08:27]

lgtm

[Siggi Cherem (dart-lang), 2017-06-01 18:29:31]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-01 18:29:32]

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/fasta.dart (right):

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/fasta.dart:228:
target.performModularTransformationsOnProgram(coreTypes, program);
dbc - do we still need this call? (I'm thinking that kernelTarget applies the
modular transformations internally already)

[Dmitry Stefantsov, 2017-06-02 07:52:52]

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/fasta.dart (right):

https://codereview.chromium.org/2918623004/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/fasta.dart:228:
target.performModularTransformationsOnProgram(coreTypes, program);
On 2017/06/01 18:29:31, Siggi Cherem (dart-lang) wrote:
> dbc - do we still need this call? (I'm thinking that kernelTarget applies the
> modular transformations internally already)

Good catch! I've added backendTarget.performGlobalTransformations() call to
KernelTarget.runBuildTransformations() and removed perform*Transformations* from
here. Thanks!

[Dmitry Stefantsov, 2017-06-02 08:40:22]

Description was changed from

==========
Use backend targets to run Kernel transformations in Fasta
==========

to

==========
Use backend targets to run Kernel transformations in Fasta

R=ahe@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8ff762067a9fd65513dcd711493d311791bf2774
==========

[Dmitry Stefantsov, 2017-06-02 08:40:24]

Committed patchset #4 (id:60001) manually as
8ff762067a9fd65513dcd711493d311791bf2774 (presubmit successful).