Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pkg/kernel/lib/transformations/treeshaker.dart

Issue 2918593003: Pass ClassHierarchy instead of creating it. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/transformations/treeshaker.dart
diff --git a/pkg/kernel/lib/transformations/treeshaker.dart b/pkg/kernel/lib/transformations/treeshaker.dart
index 102ec75a72043972efe50b7bab1cb7d3f754a606..b30f05db925535b9094f565c5802624b47f85777 100644
--- a/pkg/kernel/lib/transformations/treeshaker.dart
+++ b/pkg/kernel/lib/transformations/treeshaker.dart
@@ -10,9 +10,10 @@ import '../core_types.dart';
import '../type_environment.dart';
import '../library_index.dart';
-Program transformProgram(CoreTypes coreTypes, Program program,
+Program transformProgram(
+ CoreTypes coreTypes, ClassHierarchy hierarchy, Program program,
{List<ProgramRoot> programRoots}) {
- new TreeShaker(coreTypes, program, programRoots: programRoots)
+ new TreeShaker(coreTypes, hierarchy, program, programRoots: programRoots)
.transform(program);
return program;
}
@@ -90,9 +91,9 @@ class ProgramRoot {
//
// TODO(asgerf): Tree shake unused instance fields.
class TreeShaker {
- final Program program;
- final ClosedWorldClassHierarchy hierarchy;
final CoreTypes coreTypes;
+ final ClosedWorldClassHierarchy hierarchy;
+ final Program program;
final bool strongMode;
final List<ProgramRoot> programRoots;
@@ -169,12 +170,9 @@ class TreeShaker {
/// the mirrors library.
bool get forceShaking => programRoots != null && programRoots.isNotEmpty;
- TreeShaker(CoreTypes coreTypes, Program program,
- {ClassHierarchy hierarchy,
- bool strongMode: false,
- List<ProgramRoot> programRoots})
- : this._internal(program, hierarchy ?? new ClassHierarchy(program),
- coreTypes, strongMode, programRoots);
+ TreeShaker(CoreTypes coreTypes, ClassHierarchy hierarchy, Program program,
+ {bool strongMode: false, List<ProgramRoot> programRoots})
+ : this._internal(coreTypes, hierarchy, program, strongMode, programRoots);
bool isMemberBodyUsed(Member member) {
return _usedMembers.containsKey(member);
@@ -209,10 +207,9 @@ class TreeShaker {
new _TreeShakingTransformer(this).transform(program);
}
- TreeShaker._internal(this.program, ClosedWorldClassHierarchy hierarchy,
- this.coreTypes, this.strongMode, this.programRoots)
- : this.hierarchy = hierarchy,
- this._dispatchedNames = new List<Set<Name>>(hierarchy.classes.length),
+ TreeShaker._internal(this.coreTypes, this.hierarchy, this.program,
+ this.strongMode, this.programRoots)
+ : this._dispatchedNames = new List<Set<Name>>(hierarchy.classes.length),
this._usedMembersWithHost =
new List<Set<Member>>(hierarchy.classes.length),
this._classRetention = new List<ClassRetention>.filled(

Powered by Google App Engine
This is Rietveld 408576698