Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2918593003: Pass ClassHierarchy instead of creating it. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Dmitry Stefantsov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass ClassHierarchy instead of creating it. MixinFullResolution is also updated to create new ClassHierarchy instance only if there are transformed classes. This improves incremental kernel generator initial time from 22 to 16 seconds. R=ahe@google.com, kmillikin@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5bdfd1e69b140c2fc74472afadbffb8ed3455ff6

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -66 lines) Patch
M pkg/front_end/lib/src/fasta/fasta.dart View 4 chunks +5 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/kernel/bin/transform.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/kernel/lib/target/flutter.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/kernel/lib/target/vm.dart View 3 chunks +7 lines, -9 lines 0 comments Download
M pkg/kernel/lib/transformations/insert_covariance_checks.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/insert_type_checks.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/method_call.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/kernel/lib/transformations/mixin_full_resolution.dart View 3 chunks +16 lines, -9 lines 1 comment Download
M pkg/kernel/lib/transformations/treeshaker.dart View 4 chunks +11 lines, -14 lines 0 comments Download
M pkg/kernel/test/baseline_tester.dart View 4 chunks +5 lines, -2 lines 0 comments Download
M pkg/kernel/test/reify/suite.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/kernel/test/treeshaker_bench.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/kernel/test/treeshaker_check.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/kernel/test/treeshaker_dump.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/kernel/test/treeshaker_membench.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/tool/dartk.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 6 months ago (2017-05-31 21:18:32 UTC) #1
Paul Berry
lgtm assuming that Kevin or Peter agrees.
3 years, 6 months ago (2017-05-31 21:22:05 UTC) #2
ahe
lgtm https://codereview.chromium.org/2918593003/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart File pkg/kernel/lib/transformations/mixin_full_resolution.dart (right): https://codereview.chromium.org/2918593003/diff/1/pkg/kernel/lib/transformations/mixin_full_resolution.dart#newcode33 pkg/kernel/lib/transformations/mixin_full_resolution.dart:33: /// valid anymore. This is a good practical ...
3 years, 6 months ago (2017-06-01 11:38:29 UTC) #3
ahe
I think there may be a few conflicts with this CL: https://codereview.chromium.org/2918623004/
3 years, 6 months ago (2017-06-01 11:45:41 UTC) #4
scheglov
3 years, 6 months ago (2017-06-01 14:20:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5bdfd1e69b140c2fc74472afadbffb8ed3455ff6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698