Chromium Code Reviews| Index: pkg/analysis_server/lib/src/server/http_server.dart |
| diff --git a/pkg/analysis_server/lib/src/server/http_server.dart b/pkg/analysis_server/lib/src/server/http_server.dart |
| index 53a12e49c0e6f73f24675a8a8a486d363213101e..4ed7996b27b7159462f4c0d80796cb843e1ed0fb 100644 |
| --- a/pkg/analysis_server/lib/src/server/http_server.dart |
| +++ b/pkg/analysis_server/lib/src/server/http_server.dart |
| @@ -8,7 +8,6 @@ import 'dart:io'; |
| import 'package:analysis_server/src/channel/web_socket_channel.dart'; |
| import 'package:analysis_server/src/socket_server.dart'; |
| import 'package:analysis_server/src/status/diagnostics.dart'; |
| -import 'package:analysis_server/src/status/get_handler.dart'; |
| /** |
| * Instances of the class [HttpServer] implement a simple HTTP server. The |
| @@ -96,11 +95,10 @@ class HttpAnalysisServer { |
| void _handleGetRequest(HttpRequest request) { |
| if (getHandler == null) { |
| if (socketServer.analysisServer.options.enableNewAnalysisDriver) { |
| - // TODO(devoncarew): Remove GetHandler2. |
| getHandler = new DiagnosticsSite(socketServer, _printBuffer); |
| } else { |
| - // TODO(devoncarew): GetHandler is essentially dead code. |
| - getHandler = new GetHandler(socketServer, _printBuffer); |
| + getHandler = new ErrorGetHandler( |
| + 'Diagnostics only supported for the new analysis driver.'); |
| } |
| } |
| getHandler.handleGetRequest(request); |
| @@ -158,3 +156,21 @@ abstract class AbstractGetHandler { |
| */ |
| void handleGetRequest(HttpRequest request); |
| } |
| + |
| +/** |
| + * A [AbstractGetHandler] that always returns the given error message. |
|
Brian Wilkerson
2017/05/31 14:54:43
nit: "A" --> "An"
devoncarew
2017/06/01 16:59:11
Done.
|
| + */ |
| +class ErrorGetHandler extends AbstractGetHandler { |
| + final String message; |
| + |
| + ErrorGetHandler(this.message); |
| + |
| + @override |
| + void handleGetRequest(HttpRequest request) { |
| + HttpResponse response = request.response; |
| + response.statusCode = HttpStatus.NOT_FOUND; |
| + response.headers.contentType = ContentType.TEXT; |
| + response.write(message); |
| + response.close(); |
| + } |
| +} |