Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2918543003: Handle static invocation (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle static invocation + implement Sorter for kernel entities. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9c782896e9213b480641ad7ae0681e1d6f2c7211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -96 lines) Patch
M pkg/compiler/lib/src/closure.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 3 chunks +7 lines, -78 lines 0 comments Download
A pkg/compiler/lib/src/elements/entity_utils.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 5 chunks +58 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-05-31 14:13:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm!
3 years, 6 months ago (2017-05-31 21:19:57 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-06-01 08:00:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c782896e9213b480641ad7ae0681e1d6f2c7211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698