Send metrics with embedded system profiles after system startup.

components/metrics/persistent_system_profile_unittest.cc

Index: components/metrics/persistent_system_profile_unittest.cc
diff --git a/components/metrics/persistent_system_profile_unittest.cc b/components/metrics/persistent_system_profile_unittest.cc
index 93f297a81cddb017b7dd96058f56d29017f62bc9..5ca4e898637f28e3a37e043b7a756afecea06dee 100644
--- a/components/metrics/persistent_system_profile_unittest.cc
+++ b/components/metrics/persistent_system_profile_unittest.cc
@@ -91,11 +91,10 @@ TEST_F(PersistentSystemProfileTest, ProfileStorage) {
   trial->set_name_id(123);
   trial->set_group_id(456);
 
-  std::string serialized_proto;
-  ASSERT_TRUE(proto1.SerializeToString(&serialized_proto));
-  persistent_profile()->SetSystemProfile(serialized_proto);
+  persistent_profile()->SetSystemProfile(proto1);

[Alexei Svitkine (slow), 2017/06/08 23:59:31]

Nit: Name the new function that takes the proto SetSystemProfileProto().

[bcwhite, 2017/06/09 15:09:28]

It's setting a "profile", not a "profile proto" so I don't think the method name
should change.  It's describing what its doing, not what the parameter is.  The
overloaded nature just allows multiple ways of doing the same thing based on the
source information available.

 
   SystemProfileProto proto2;
+  ASSERT_TRUE(PersistentSystemProfile::HasSystemProfile(*memory_allocator()));
   ASSERT_TRUE(
       PersistentSystemProfile::GetSystemProfile(*memory_allocator(), &proto2));
   ASSERT_EQ(1, proto2.field_trial_size());
@@ -108,8 +107,7 @@ TEST_F(PersistentSystemProfileTest, ProfileStorage) {
   trial->set_name_id(78);
   trial->set_group_id(90);
 
-  ASSERT_TRUE(proto1.SerializeToString(&serialized_proto));
-  persistent_profile()->SetSystemProfile(serialized_proto);
+  persistent_profile()->SetSystemProfile(proto1);
 
   ASSERT_TRUE(
       PersistentSystemProfile::GetSystemProfile(*memory_allocator(), &proto2));