Send metrics with embedded system profiles after system startup.

components/metrics/persistent_system_profile_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/persistent_system_profile.h"
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/persistent_memory_allocator.h"
 #include "base/rand_util.h"
@@ skipping 73 matching lines @@
   for (size_t i = 0; i < kRecordSize; ++i)
     EXPECT_EQ(buffer[i], record[i]);
 }
 
 TEST_F(PersistentSystemProfileTest, ProfileStorage) {
   SystemProfileProto proto1;
   SystemProfileProto::FieldTrial* trial = proto1.add_field_trial();
   trial->set_name_id(123);
   trial->set_group_id(456);
 
-  std::string serialized_proto;
-  ASSERT_TRUE(proto1.SerializeToString(&serialized_proto));
-  persistent_profile()->SetSystemProfile(serialized_proto);
+  persistent_profile()->SetSystemProfile(proto1);

[Alexei Svitkine (slow), 2017/06/08 23:59:31]

Nit: Name the new function that takes the proto SetSystemProfileProto().

[bcwhite, 2017/06/09 15:09:28]

It's setting a "profile", not a "profile proto" so I don't think the method name
should change.  It's describing what its doing, not what the parameter is.  The
overloaded nature just allows multiple ways of doing the same thing based on the
source information available.

 
   SystemProfileProto proto2;
+  ASSERT_TRUE(PersistentSystemProfile::HasSystemProfile(*memory_allocator()));
   ASSERT_TRUE(
       PersistentSystemProfile::GetSystemProfile(*memory_allocator(), &proto2));
   ASSERT_EQ(1, proto2.field_trial_size());
   EXPECT_EQ(123U, proto2.field_trial(0).name_id());
   EXPECT_EQ(456U, proto2.field_trial(0).group_id());
 
   // Check that the profile can be overwritten.
 
   trial = proto1.add_field_trial();
   trial->set_name_id(78);
   trial->set_group_id(90);
 
-  ASSERT_TRUE(proto1.SerializeToString(&serialized_proto));
-  persistent_profile()->SetSystemProfile(serialized_proto);
+  persistent_profile()->SetSystemProfile(proto1);
 
   ASSERT_TRUE(
       PersistentSystemProfile::GetSystemProfile(*memory_allocator(), &proto2));
   ASSERT_EQ(2, proto2.field_trial_size());
   EXPECT_EQ(123U, proto2.field_trial(0).name_id());
   EXPECT_EQ(456U, proto2.field_trial(0).group_id());
   EXPECT_EQ(78U, proto2.field_trial(1).name_id());
   EXPECT_EQ(90U, proto2.field_trial(1).group_id());
 }
 
 }  // namespace metrics