Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 291853004: Update Ahem capitalization in LayoutTests (Closed)

Created:
6 years, 7 months ago by eae
Modified:
6 years, 7 months ago
CC:
blink-reviews, cbiesinger, mstensho+blink_opera.com
Visibility:
Public.

Description

Update Ahem capitalization in LayoutTests The way tests fonts are side loaded when running layout tests on Windows with DirectWrite requires the name to be specified with the correct case as matching is case sensitive. This is different from how normal system fonts are handled but as this facility is only used for layout tests the extra overhead of implementing case insensitive matching doesn't seem worth it. This change updated all layout tests using the Ahem font as a test provided system font to request it using "Ahem". BUG=333029 R=dglazkov@chromium.org, cpu@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -77 lines) Patch
M LayoutTests/editing/selection/caret-alignment-for-vertical-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/selection/script-tests/click-in-margins-inside-editable-div.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/block-with-inline-replaced-child-following-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/float/float-not-removed-from-next-sibling.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/float/float-not-removed-from-next-sibling2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/float/float-not-removed-from-next-sibling3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/float/float-not-removed-from-next-sibling4.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/line-layout/selection-highlight-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/before-content-continuation-chain.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/first-letter-in-nested-before.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/css-generated-content/table-parts-before-and-after.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/first-letter-set-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/pseudo-first-line-border-width.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/text-decoration-propagate.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/text-decoration-propagate-expected.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/css/user-drag-none.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/dynamic/first-letter-after-list-marker.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dynamic/first-letter-display-change.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/flexbox/overhanging-floats-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/inline/continuation-outlines-with-layers-2.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/lists/inline-before-content-after-list-marker.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/multicol/client-rects.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/client-rects.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/client-rects-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/span/before-child-anonymous-column-block.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/span/clone-flexbox.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/span/clone-summary.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/multicol/span/generated-child-split-flow-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/split-in-top-margin.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/multicol/split-in-top-margin-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/table-row-height-increase.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/multicol/vertical-rl/float-truncation.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/inline-relative-positioned.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/ruby/float-overhang-from-ruby-text.html View 1 chunk +1 line, -1 line 0 comments Download
LayoutTests/fast/ruby/floating-ruby-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-horizontal.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-horizontal-no-overlap1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-horizontal-no-overlap2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-vertical.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-vertical-no-overlap1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/overhang-vertical-no-overlap2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/positioned-ruby-text.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/ruby/ruby-text-before-child-split.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/css-table-width-with-border-padding.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-anonymous-cell-bug.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-anonymous-row-bug.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-anonymous-section-bug.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-cell-split.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-insert-before-non-anonymous-block.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-row-before-after-content-around-table-cell.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-row-split.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-row-split2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-section-split.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-section-split-with-after-content.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-section-split2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-split.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/table/table-split2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/bidi-explicit-embedding-past-end.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/emphasis-avoid-ruby.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/emphasis-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/justification-padding-mid-word.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/text/justify-padding-distribution.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/remove-zero-length-run.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/setData-dirty-lines.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/shadow-translucent-fill.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/splitText-dirty-lines.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/word-space-with-kerning.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/word-space-with-kerning-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/word-space-with-kerning-3-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/word-space-with-kerning-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/zero-font-size-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fullscreen/parent-flow-inline-with-block-child.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
6 years, 7 months ago (2014-05-19 20:30:50 UTC) #1
eae
6 years, 7 months ago (2014-05-19 21:15:34 UTC) #2
eae
This is pretty much a search and replace change, the only changes are s/ahem/Ahem/.
6 years, 7 months ago (2014-05-19 22:59:23 UTC) #3
dglazkov
rslgtm
6 years, 7 months ago (2014-05-19 23:01:26 UTC) #4
eae
Thanks Dimitri. To unsubscribe from this group and stop receiving emails from it, send an ...
6 years, 7 months ago (2014-05-19 23:01:41 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 7 months ago (2014-05-19 23:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/291853004/1
6 years, 7 months ago (2014-05-19 23:02:05 UTC) #7
eae
6 years, 7 months ago (2014-05-19 23:26:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r174325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698