Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1169)

Unified Diff: components/ntp_snippets/breaking_news/subscription_json_request.h

Issue 2918513002: [NTP::Push] Add the classes for sending a breaking news subscription request (Closed)
Patch Set: bauerb@ comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/breaking_news/subscription_json_request.h
diff --git a/components/ntp_snippets/breaking_news/subscription_json_request.h b/components/ntp_snippets/breaking_news/subscription_json_request.h
new file mode 100644
index 0000000000000000000000000000000000000000..40ae01aeebc1f1b510063b08ec0589679ab871f0
--- /dev/null
+++ b/components/ntp_snippets/breaking_news/subscription_json_request.h
@@ -0,0 +1,114 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_
+#define COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_
+
+#include <memory>
+#include <string>
+#include <utility>
+
+#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
+#include "base/optional.h"
+#include "base/time/time.h"
+#include "components/ntp_snippets/breaking_news/subscription_request_params.h"
+#include "components/ntp_snippets/status.h"
+#include "components/translate/core/browser/language_model.h"
+#include "google_apis/gaia/oauth2_token_service.h"
+#include "net/http/http_request_headers.h"
+
+namespace base {
+class Value;
+} // namespace base
+
+namespace ntp_snippets {
+
+namespace internal {
+
+// A single request to subscribe for breaking news via GCM,
+class SubscriptionJsonRequest : public net::URLFetcherDelegate {
+ public:
+ // A client can expect error_details only, if there was any error during the
+ // subscription or parsing. In successful cases, it will be an empty string.
+ using CompletedCallback =
+ base::OnceCallback<void(std::unique_ptr<base::Value> result,
+ const std::string& error_details)>;
+
+ // Builds authenticated and non-authenticated SubscriptionJsonRequests.
+ class Builder {
+ public:
+ Builder();
+ Builder(Builder&&);
+ ~Builder();
+
+ // Builds a Request object that contains all data to fetch new snippets.
+ std::unique_ptr<SubscriptionJsonRequest> Build() const;
+
+ Builder& SetParams(const SubscriptionRequestParams& params);
+ Builder& SetUrl(const GURL& url);
+ Builder& SetUrlRequestContextGetter(
+ const scoped_refptr<net::URLRequestContextGetter>& context_getter);
+ Builder& SetParseJsonCallback(ParseJSONCallback callback);
+
+ // These preview methods allow to inspect the Request without exposing it
+ // publicly.
+ std::string PreviewRequestBodyForTesting() { return BuildBody(); }
+ std::string PreviewRequestHeadersForTesting() { return BuildHeaders(); }
+
+ private:
+ std::string BuildHeaders() const;
+ std::string BuildBody() const;
+ std::unique_ptr<net::URLFetcher> BuildURLFetcher(
+ net::URLFetcherDelegate* request,
+ const std::string& headers,
+ const std::string& body) const;
+
+ // Only required, if the request needs to be sent.
+ std::string auth_header_;
+ SubscriptionRequestParams params_;
+ ParseJSONCallback parse_json_callback_;
+ GURL url_;
+ scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
+
+ // Optional properties.
+ std::string obfuscated_gaia_id_;
+
+ DISALLOW_COPY_AND_ASSIGN(Builder);
+ };
+
+ SubscriptionJsonRequest(SubscriptionJsonRequest&&);
+ ~SubscriptionJsonRequest() override;
+
+ void Start(CompletedCallback callback);
+
+ std::string GetResponseString() const;
+
+ private:
+ friend class Builder;
+ SubscriptionJsonRequest(const ParseJSONCallback& callback);
+ // URLFetcherDelegate implementation.
+ void OnURLFetchComplete(const net::URLFetcher* source) override;
+
+ // The fetcher for subscribing. Only non-null if a subscription process is
+ // currently ongoing.
+ std::unique_ptr<net::URLFetcher> url_fetcher_;
+
+ // This callback is called to parse a json string. It contains callbacks for
+ // error and success cases.
+ ParseJSONCallback parse_json_callback_;
+
+ // The callback to notify when URLFetcher finished and results are available.
+ CompletedCallback request_completed_callback_;
+
+ base::WeakPtrFactory<SubscriptionJsonRequest> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SubscriptionJsonRequest);
+};
+
+} // namespace internal
+
+} // namespace ntp_snippets
+
+#endif // COMPONENTS_NTP_SNIPPETS_BREAKING_NEWS_SUBSCRIPTION_JSON_REQUEST_H_

Powered by Google App Engine
This is Rietveld 408576698